Skip to content

Fix leaking curved animation. [prod-leak-fix] - #146644

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
polina-c:fix-leaks1
Apr 11, 2024
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
polina-c:fix-leaks1

Conversation

@polina-c

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Apr 11, 2024
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 11, 2024
}, skip: isBrowser); // TODO(yjbanov): cupertino does not work on the Web yet: https://github.com/flutter/flutter/issues/41920

testWidgets('RangeSlider relayout upon system fonts changes', (WidgetTester tester) async {
testWidgets('RangeSlider relayout upon system fonts changes more than once', (WidgetTester tester) async {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand why this test name changed

@polina-c polina-c Apr 11, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two tests with the same name in this file.

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2024
@auto-submit
auto-submit Bot merged commit 5ebc940 into flutter:master Apr 11, 2024
@polina-c
polina-c deleted the fix-leaks1 branch April 11, 2024 21:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 12, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c changed the title Fix leaking curved animation. Fix leaking curved animation. [prod-leak-fix] Aug 29, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 3982be2 to 5236157 (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants