Add default arguments to `AnimatedPhysicalModel` by nate-thegrate · Pull Request #147424 · flutter/flutter

nate-thegrate · 2024-04-26T16:39:59Z

Currently, PhysicalModel has default arguments for shape and elevation, but AnimatedPhysicalModel does not.

This pull request makes both classes consistent.

Hixie · 2024-04-26T17:41:19Z

We should still test this, ideally (checking that there is a default and that it's the one we expect).

…d counterpart

goderbauer · 2024-04-29T16:16:01Z

    this.clipBehavior = Clip.none,
-    this.borderRadius = BorderRadius.zero,
-    required this.elevation,
+    this.borderRadius,


Why remove the explicit default value for borderRadius?

The non-animated class has a nullable border radius, so this change makes them consistent.

goderbauer

LGTM

nate-thegrate · 2024-05-02T21:58:13Z

Guess who's able to add labels now 😎😎😎

goderbauer · 2024-05-02T22:01:50Z

Guess who's able to add labels now 😎😎😎

🥳 Welcome to flutter-hackers!

…tter#147424)

flutter/flutter@bf7191f...f1037a0 2024-05-03 [email protected] Roll Flutter Engine from 445c3bfc0d5b to 8cce00433073 (1 revision) (flutter/flutter#147778) 2024-05-03 [email protected] Roll Flutter Engine from 1f9edbeeceb3 to 445c3bfc0d5b (1 revision) (flutter/flutter#147776) 2024-05-03 [email protected] Roll Flutter Engine from 75eb18090510 to 1f9edbeeceb3 (1 revision) (flutter/flutter#147769) 2024-05-03 [email protected] Improved documentation for SpringSimulation (flutter/flutter#146674) 2024-05-03 [email protected] Roll Flutter Engine from b8d81a4f6e5a to 75eb18090510 (1 revision) (flutter/flutter#147766) 2024-05-03 [email protected] Roll Flutter Engine from d8c8cf4384f0 to b8d81a4f6e5a (2 revisions) (flutter/flutter#147765) 2024-05-03 [email protected] Move snippets package back into flutter repo (flutter/flutter#147690) 2024-05-03 [email protected] Roll Flutter Engine from 98a800b00cfc to d8c8cf4384f0 (2 revisions) (flutter/flutter#147763) 2024-05-03 [email protected] Roll Flutter Engine from c380e9fd4122 to 98a800b00cfc (3 revisions) (flutter/flutter#147761) 2024-05-03 [email protected] Roll Flutter Engine from fc71b650a70a to c380e9fd4122 (4 revisions) (flutter/flutter#147759) 2024-05-03 [email protected] Roll pub packages (flutter/flutter#147741) 2024-05-03 [email protected] Roll Flutter Engine from 3f1f81915620 to fc71b650a70a (2 revisions) (flutter/flutter#147753) 2024-05-02 [email protected] Roll Flutter Engine from 5088f63ecee2 to 3f1f81915620 (3 revisions) (flutter/flutter#147748) 2024-05-02 [email protected] [web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (flutter/flutter#147736) 2024-05-02 [email protected] Control flow collections: `flutter_tools/` (flutter/flutter#147450) 2024-05-02 [email protected] Add default arguments to `AnimatedPhysicalModel` (flutter/flutter#147424) 2024-05-02 [email protected] Roll Flutter Engine from 9982b5ffd913 to 5088f63ecee2 (3 revisions) (flutter/flutter#147740) 2024-05-02 [email protected] `_RenderDecorator.computeDryBaseline` (flutter/flutter#146365) 2024-05-02 [email protected] Roll Flutter Engine from e1126e59b698 to 9982b5ffd913 (1 revision) (flutter/flutter#147727) 2024-05-02 [email protected] [web] increase chromedriver logging level (flutter/flutter#147687) 2024-05-02 [email protected] Roll Flutter Engine from 1fb36ac9d718 to e1126e59b698 (1 revision) (flutter/flutter#147720) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#147424)

flutter/flutter@bf7191f...f1037a0 2024-05-03 [email protected] Roll Flutter Engine from 445c3bfc0d5b to 8cce00433073 (1 revision) (flutter/flutter#147778) 2024-05-03 [email protected] Roll Flutter Engine from 1f9edbeeceb3 to 445c3bfc0d5b (1 revision) (flutter/flutter#147776) 2024-05-03 [email protected] Roll Flutter Engine from 75eb18090510 to 1f9edbeeceb3 (1 revision) (flutter/flutter#147769) 2024-05-03 [email protected] Improved documentation for SpringSimulation (flutter/flutter#146674) 2024-05-03 [email protected] Roll Flutter Engine from b8d81a4f6e5a to 75eb18090510 (1 revision) (flutter/flutter#147766) 2024-05-03 [email protected] Roll Flutter Engine from d8c8cf4384f0 to b8d81a4f6e5a (2 revisions) (flutter/flutter#147765) 2024-05-03 [email protected] Move snippets package back into flutter repo (flutter/flutter#147690) 2024-05-03 [email protected] Roll Flutter Engine from 98a800b00cfc to d8c8cf4384f0 (2 revisions) (flutter/flutter#147763) 2024-05-03 [email protected] Roll Flutter Engine from c380e9fd4122 to 98a800b00cfc (3 revisions) (flutter/flutter#147761) 2024-05-03 [email protected] Roll Flutter Engine from fc71b650a70a to c380e9fd4122 (4 revisions) (flutter/flutter#147759) 2024-05-03 [email protected] Roll pub packages (flutter/flutter#147741) 2024-05-03 [email protected] Roll Flutter Engine from 3f1f81915620 to fc71b650a70a (2 revisions) (flutter/flutter#147753) 2024-05-02 [email protected] Roll Flutter Engine from 5088f63ecee2 to 3f1f81915620 (3 revisions) (flutter/flutter#147748) 2024-05-02 [email protected] [web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (flutter/flutter#147736) 2024-05-02 [email protected] Control flow collections: `flutter_tools/` (flutter/flutter#147450) 2024-05-02 [email protected] Add default arguments to `AnimatedPhysicalModel` (flutter/flutter#147424) 2024-05-02 [email protected] Roll Flutter Engine from 9982b5ffd913 to 5088f63ecee2 (3 revisions) (flutter/flutter#147740) 2024-05-02 [email protected] `_RenderDecorator.computeDryBaseline` (flutter/flutter#146365) 2024-05-02 [email protected] Roll Flutter Engine from e1126e59b698 to 9982b5ffd913 (1 revision) (flutter/flutter#147727) 2024-05-02 [email protected] [web] increase chromedriver logging level (flutter/flutter#147687) 2024-05-02 [email protected] Roll Flutter Engine from 1fb36ac9d718 to e1126e59b698 (1 revision) (flutter/flutter#147720) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

add default argument

3ba9eb0

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs p: material_ui material_ui package in flutter/packages labels Apr 26, 2024

nate-thegrate marked this pull request as draft April 26, 2024 17:38

add new test!

0f3fbd2

nate-thegrate marked this pull request as ready for review April 26, 2024 17:53

nate-thegrate added 3 commits April 26, 2024 11:54

whitespace

e788978

change year

61c6aad

update test

49f1a80

HansMuller requested a review from goderbauer April 26, 2024 21:59

nate-thegrate added 4 commits April 27, 2024 10:31

add another default arg :)

da8507d

move test into implicit_animations_test.dart

d58f0e7

Merge branch 'master' into animatedphysicalmodel-default-argument

1c71e10

fix analysis problem

1b307be

nate-thegrate changed the title ~~Add default argument to AnimatedPhysicalModel~~ Add default arguments to AnimatedPhysicalModel Apr 27, 2024

make AnimatedPhysicalModel.borderRadius nullable to match non-animate…

625a9c5

…d counterpart

goderbauer reviewed Apr 29, 2024

View reviewed changes

goderbauer approved these changes Apr 29, 2024

View reviewed changes

Merge branch 'master' into animatedphysicalmodel-default-argument

df1494b

nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024

auto-submit Bot merged commit 7436cc2 into flutter:master May 2, 2024

nate-thegrate deleted the animatedphysicalmodel-default-argument branch May 2, 2024 21:59

engine-flutter-autoroll mentioned this pull request May 3, 2024

Roll Flutter from bf7191fd3884 to f1037a01b796 (21 revisions) flutter/packages#6641

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2024

7436cc2 Add default arguments to AnimatedPhysicalModel (flutter/flu…

7d3a5ae

…tter#147424)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

7436cc2 Add default arguments to AnimatedPhysicalModel (flutter/flu…

bf6b927

…tter#147424)

Navigation Menu

Repository navigation

Add default arguments to `AnimatedPhysicalModel` - #147424

Add default arguments to `AnimatedPhysicalModel`#147424
auto-submit[bot] merged 11 commits into
flutter:masterfrom
nate-thegrate:animatedphysicalmodel-default-argument

nate-thegrate commented Apr 26, 2024 •

edited

Loading

Uh oh!

Hixie commented Apr 26, 2024

Uh oh!

goderbauer Apr 29, 2024

Uh oh!

nate-thegrate Apr 29, 2024

Uh oh!

goderbauer left a comment

Uh oh!

nate-thegrate commented May 2, 2024

Uh oh!

goderbauer commented May 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nate-thegrate commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hixie commented Apr 26, 2024

Uh oh!

goderbauer Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

nate-thegrate commented May 2, 2024

Uh oh!

goderbauer commented May 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nate-thegrate commented Apr 26, 2024 •

edited

Loading