Skip to content

Add tests for single_activator.0.dart API example. - #147426

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
ksokolovskyi:add-single-activator-example-tests
May 1, 2024
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
ksokolovskyi:add-single-activator-example-tests

Conversation

@ksokolovskyi

Copy link
Copy Markdown
Contributor

This PR contributes to #130459

Description

  • Fixes name of the examples/api/lib/widgets/shortcuts/single_activator.single_activator.0.dart
  • Adds tests for examples/api/lib/widgets/shortcuts/single_activator.0.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 26, 2024

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding these tests!

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2024
@auto-submit
auto-submit Bot merged commit d33bb8f into flutter:master May 1, 2024
@ksokolovskyi

Copy link
Copy Markdown
Contributor Author

@Renzo-Olivares @goderbauer thanks for the review!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 1, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Poâ�¦ (flutter/flutter#147597)
2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 [email protected] Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Poâ�¦ (flutter/flutter#147597)
2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 [email protected] Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@b597dd2...d33bb8f

2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Poâ�¦ (flutter/flutter#147597)
2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 [email protected] Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@b597dd2...d33bb8f

2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Poâ�¦ (flutter/flutter#147597)
2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 [email protected] Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants