Skip to content

Make Podfiles use symlinks to local pods - #14748

Merged
mravn-google merged 6 commits into
flutter:masterfrom
mravn-google:podfile_lock
Feb 19, 2018
Merged

mravn-google merged 6 commits into
flutter:masterfrom
mravn-google:podfile_lock

Conversation

@mravn-google

Copy link
Copy Markdown
Contributor

Fixes #9502

@jakobr-google jakobr-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google

Copy link
Copy Markdown
Contributor Author

/cc @mit-mit who might like to test this in light of #9502 (comment)

@xster

xster commented Feb 16, 2018 •

Copy link
Copy Markdown
Member

Awesome, cool!
LGTM

I wonder if we can put these symlinks in the /Pods directory to keep them bundled. This way, it 'self documents' too when the users are exploring the directories. Wonder if pod deintegrate would clean up everything nicely for us if it were inside /Pods.

@mravn-google

Copy link
Copy Markdown
Contributor Author

I wonder if we can put these symlinks in the /Pods directory to keep them bundled. This way, it 'self documents' too when the users are exploring the directories. Wonder if pod deintegrate would clean up everything nicely for us if it were inside /Pods.

Yes, I'll give it a try at least. One may worry that we'll be making assumptions about the detailed workings of pod install. Changes to the timing or the extend to which it clears the Pods/ folder could affect correctness down the road.

@mravn-google

mravn-google commented Feb 19, 2018 •

Copy link
Copy Markdown
Contributor Author
  • Moved Symlinks folder to Pods/.symlinks
  • Now copying Flutter framework's LICENSE file to sibling of Flutter framework podspecs in cache. This avoids issue with resolving ../../../../../ relative to symlink.

Awaits merge and roll of flutter-team-archive/engine#4691 which updates the LICENSE placement in Flutter.podspec.

@mravn-google

mravn-google commented Feb 19, 2018 •

Copy link
Copy Markdown
Contributor Author

@xster , @jakobr-google PTAL

/ServiceDefinitions.json

Pods/
Symlinks/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jakobr-google jakobr-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A Flutter app's Podfile.lock should be versionable

4 participants