test focus example 0 by derdilla · Pull Request #147564 · flutter/flutter

derdilla · 2024-04-30T07:29:32Z

Part of #130459. Adds tests for Focus example 0.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gspencergoog

auto-submit · 2024-05-02T01:05:57Z

auto label is removed for flutter/flutter/147564, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

derdilla · 2024-05-03T11:36:45Z

@gspencergoog can you run Google testing again? I don't see how this could break anything.

gspencergoog · 2024-05-07T00:59:24Z

Done. It will work this time.

flutter/flutter@04424e1...7920a52 2024-05-07 [email protected] Add tests for callback_shortcuts.0.dart API example. (flutter/flutter#147536) 2024-05-07 [email protected] Improve Android SDK and NDK mistmatch warning message (flutter/flutter#147809) 2024-05-07 [email protected] Add tests for shortcuts.dart API examples. (flutter/flutter#147433) 2024-05-07 [email protected] Added missing tests for ButtonStyle example (flutter/flutter#147457) 2024-05-07 [email protected] Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (flutter/flutter#147912) 2024-05-07 [email protected] DropdownMenu cleanup (flutter/flutter#147860) 2024-05-07 [email protected] Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (flutter/flutter#147910) 2024-05-07 [email protected] Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (flutter/flutter#147906) 2024-05-07 [email protected] Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (flutter/flutter#147905) 2024-05-07 [email protected] fix MenuItemButton if child is null (flutter/flutter#147485) 2024-05-07 [email protected] Fix document generation, eliminate template support from snippets tool. (flutter/flutter#147893) 2024-05-07 [email protected] Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (flutter/flutter#147904) 2024-05-07 [email protected] test focus example 0 (flutter/flutter#147564) 2024-05-07 [email protected] Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (flutter/flutter#147899) 2024-05-06 [email protected] Roll pub packages (flutter/flutter#147896) 2024-05-06 [email protected] Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (flutter/flutter#147895) 2024-05-06 [email protected] MultiSelectableSelectionContainerDelegate documentation fixes. (flutter/flutter#147843) 2024-05-06 [email protected] Roll pub packages (flutter/flutter#147891) 2024-05-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/flutter#147888) 2024-05-06 [email protected] Fix janks and memory leaks in `CupertinoPageTransition` and `CupertinoFullscreenDialogTransition` (flutter/flutter#146999) 2024-05-06 [email protected] Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (flutter/flutter#147886) 2024-05-06 [email protected] Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (flutter/flutter#147884) 2024-05-06 [email protected] [new gallery] Reisze gallery images (flutter/flutter#147882) 2024-05-06 [email protected] Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (flutter/flutter#147880) 2024-05-06 [email protected] Fix leak in a test. (flutter/flutter#147846) 2024-05-06 [email protected] Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (flutter/flutter#147878) 2024-05-06 [email protected] Roll Packages from f4719ca to 2dfe645 (3 revisions) (flutter/flutter#147866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@04424e1...7920a52 2024-05-07 [email protected] Add tests for callback_shortcuts.0.dart API example. (flutter/flutter#147536) 2024-05-07 [email protected] Improve Android SDK and NDK mistmatch warning message (flutter/flutter#147809) 2024-05-07 [email protected] Add tests for shortcuts.dart API examples. (flutter/flutter#147433) 2024-05-07 [email protected] Added missing tests for ButtonStyle example (flutter/flutter#147457) 2024-05-07 [email protected] Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (flutter/flutter#147912) 2024-05-07 [email protected] DropdownMenu cleanup (flutter/flutter#147860) 2024-05-07 [email protected] Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (flutter/flutter#147910) 2024-05-07 [email protected] Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (flutter/flutter#147906) 2024-05-07 [email protected] Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (flutter/flutter#147905) 2024-05-07 [email protected] fix MenuItemButton if child is null (flutter/flutter#147485) 2024-05-07 [email protected] Fix document generation, eliminate template support from snippets tool. (flutter/flutter#147893) 2024-05-07 [email protected] Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (flutter/flutter#147904) 2024-05-07 [email protected] test focus example 0 (flutter/flutter#147564) 2024-05-07 [email protected] Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (flutter/flutter#147899) 2024-05-06 [email protected] Roll pub packages (flutter/flutter#147896) 2024-05-06 [email protected] Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (flutter/flutter#147895) 2024-05-06 [email protected] MultiSelectableSelectionContainerDelegate documentation fixes. (flutter/flutter#147843) 2024-05-06 [email protected] Roll pub packages (flutter/flutter#147891) 2024-05-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/flutter#147888) 2024-05-06 [email protected] Fix janks and memory leaks in `CupertinoPageTransition` and `CupertinoFullscreenDialogTransition` (flutter/flutter#146999) 2024-05-06 [email protected] Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (flutter/flutter#147886) 2024-05-06 [email protected] Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (flutter/flutter#147884) 2024-05-06 [email protected] [new gallery] Reisze gallery images (flutter/flutter#147882) 2024-05-06 [email protected] Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (flutter/flutter#147880) 2024-05-06 [email protected] Fix leak in a test. (flutter/flutter#147846) 2024-05-06 [email protected] Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (flutter/flutter#147878) 2024-05-06 [email protected] Roll Packages from 601aa6e to c1041b1 (3 revisions) (flutter/flutter#147866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

derdilla added 2 commits April 30, 2024 09:25

test focus example 0

f4e41de

remove missing test exemption

955e619

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels Apr 30, 2024

goderbauer requested a review from gspencergoog April 30, 2024 22:10

gspencergoog approved these changes May 1, 2024

View reviewed changes

victorsanni approved these changes May 1, 2024

View reviewed changes

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024

auto-submit Bot merged commit 5ecd4ea into flutter:master May 7, 2024

engine-flutter-autoroll mentioned this pull request May 7, 2024

Roll Flutter from 04424e10fe28 to 28e65b781105 (25 revisions) flutter/packages#6681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024

5ecd4ea test focus example 0 (flutter/flutter#147564)

cdd80a9

engine-flutter-autoroll mentioned this pull request May 7, 2024

Roll Flutter from 04424e10fe28 to 7920a52dd568 (27 revisions) flutter/packages#6683

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024

5ecd4ea test focus example 0 (flutter/flutter#147564)

c4ad432

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

5ecd4ea test focus example 0 (flutter/flutter#147564)

de1c7ac

Navigation Menu

Repository navigation

test focus example 0 - #147564

test focus example 0#147564
auto-submit[bot] merged 2 commits into
flutter:masterfrom
derdilla:130459-focus_scope-focus-0_test

derdilla commented Apr 30, 2024 •

edited

Loading

Uh oh!

gspencergoog left a comment

Uh oh!

auto-submit Bot commented May 2, 2024

Uh oh!

derdilla commented May 3, 2024

Uh oh!

gspencergoog commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

derdilla commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented May 2, 2024

Uh oh!

derdilla commented May 3, 2024

Uh oh!

gspencergoog commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

derdilla commented Apr 30, 2024 •

edited

Loading