Skip to content

Add tests for shared_app_data.#.dart API examples. - #147830

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
ksokolovskyi:add-shared-app-data-example-tests
May 20, 2024
Merged

Add tests for shared_app_data.#.dart API examples.#147830
auto-submit[bot] merged 7 commits into
flutter:masterfrom
ksokolovskyi:add-shared-app-data-example-tests

Conversation

@ksokolovskyi

@ksokolovskyi ksokolovskyi commented May 4, 2024

Copy link
Copy Markdown
Contributor

This PR contributes to #130459

Description

  • Updates examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart to meet latest API examples structure
  • Updates examples/api/lib/widgets/shared_app_data/shared_app_data.1.dart to meet latest API examples structure
  • Adds tests for examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart
  • Adds tests for examples/api/lib/widgets/shared_app_data/shared_app_data.1.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 4, 2024
@goderbauer
goderbauer requested review from TahaTesser and bleroux May 7, 2024 22:11
@ksokolovskyi
ksokolovskyi force-pushed the add-shared-app-data-example-tests branch from ba32cb6 to c7b493b Compare May 8, 2024 15:24
@ksokolovskyi

ksokolovskyi commented May 13, 2024

Copy link
Copy Markdown
Contributor Author

@bleroux could you please look at this PR when you have time?

bleroux
bleroux approved these changes May 14, 2024
View reviewed changes

@bleroux bleroux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution. Taha and I are attending Google I/O this week so we will probably catch up on pending reviews next week.

Comment thread examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart Outdated

@bleroux bleroux May 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: consider capitalizing the first letter and adding a final dot.
Same on line 62.

@ksokolovskyi ksokolovskyi May 14, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bleroux thanks for the review and the information. Have a great time!

TahaTesser
TahaTesser suggested changes May 20, 2024
View reviewed changes

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment thread examples/api/test/widgets/shared_app_data/shared_app_data.0_test.dart Outdated
Comment thread examples/api/test/widgets/shared_app_data/shared_app_data.0_test.dart Outdated
@ksokolovskyi
ksokolovskyi force-pushed the add-shared-app-data-example-tests branch from 4dff08f to d447821 Compare May 20, 2024 10:05
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit
auto-submit Bot merged commit d9cf066 into flutter:master May 20, 2024
@ksokolovskyi

ksokolovskyi commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

@bleroux @TahaTesser thanks for the review and merge!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2024
@engine-flutter-autoroll
d9cf066 Add tests for shared_app_data.#.dart API examples. (flutter/f…
ec50578 
…lutter#147830)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 21, 2024
@engine-flutter-autoroll
Roll Flutter from 02a6c91 to d02292d (22 revisions) (#6778)
1b1b5e3 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 22, 2024
@hello-coder-xu
Merge branch 'fix/slider_text_null_error' of https://github.com/hello…
74fa6d2 
…-coder-xu/flutter into fix/slider_text_null_error

* 'fix/slider_text_null_error' of https://github.com/hello-coder-xu/flutter: (65 commits)
  Change implementation method
  fix slider text null error
  Make FileSystem dependency explicit througout (more). (flutter#148095)
  Remove add-to-app bitcode warning (flutter#148587)
  SelectionArea's selection should not be cleared on loss of window focus (flutter#148067)
  [wiki migration] Engine team pages (flutter#148696)
  Manual roll camera dependency (flutter#148426)
  [wiki migration] Framework team pages (flutter#148721)
  Roll Flutter Engine from a8fb9da to c2ef01f (3 revisions) (flutter#148722)
  Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter#148715)
  Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter#148714)
  Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter#148580)
  Roll Flutter Engine from c6fecf6 to a8fb9da (3 revisions) (flutter#148700)
  Remove the no-shuffle tag on the flutter_tools create_test suite (flutter#148688)
  log incoming vm service messages in `FlutterVMService::runInView` (flutter#148596)
  Add tests for shared_app_data.#.dart API examples. (flutter#147830)
  Add tests for logical_key_set.0.dart API example. (flutter#147735)
  [wiki migration] Ecosystem team pages (flutter#148589)
  Fix painting API examples tests directories structure. (flutter#148177)
  fixes `CupertinoModalPopupRoute` (flutter#147823)
  ...
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter#6778)
e4ff699 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
d9cf066 Add tests for shared_app_data.#.dart API examples. (flutter/f…
daa370d 
…lutter#147830)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter#6778)
370ac71 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter#6778)
c7d5770 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bleroux bleroux bleroux approved these changes
+1 more reviewer
@TahaTesser TahaTesser TahaTesser approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ksokolovskyi @bleroux @TahaTesser