Skip to content

allow changing textAlign of TextField in DropdownMenu - #148074

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
angelocordero:147991
May 30, 2024
Merged

allow changing textAlign of TextField in DropdownMenu#148074
auto-submit[bot] merged 5 commits into
flutter:masterfrom
angelocordero:147991

Conversation

@angelocordero

@angelocordero angelocordero commented May 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR for #147991

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboard Bot commented May 9, 2024

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 9, 2024
ghost
ghost reviewed May 9, 2024
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

justinmc
justinmc reviewed May 9, 2024
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelocordero Can you add a test? I think just something that verifies that it was passed through is probably fine if that's easiest.

Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
@angelocordero

angelocordero commented May 11, 2024

Copy link
Copy Markdown
Contributor Author

@justinmc done adding a test and fixed the default value

@angelocordero
angelocordero requested a review from justinmc May 11, 2024 22:24
justinmc
justinmc approved these changes May 22, 2024
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Piinks
Piinks approved these changes May 23, 2024
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @angelocordero thanks for contributing! LGTM with a few nits

Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit

auto-submit Bot commented May 23, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148074, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@justinmc

justinmc commented May 23, 2024

Copy link
Copy Markdown
Contributor

@angelocordero Can you push a merge commit? Not sure why the ci.yaml validation is failing.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit

auto-submit Bot commented May 23, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148074, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@Piinks

Piinks commented May 30, 2024

Copy link
Copy Markdown
Contributor

The Google testing failure here was an infrastructure issue, the tests were not able to run. I have rebased this to give the bots a kick, hopefully everything will pass this run. :)

@auto-submit

auto-submit Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148074, due to - The status or check suite Windows build_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@auto-submit
auto-submit Bot merged commit 11cbe41 into flutter:master May 30, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
5cb9a54 
…r/flutter#148074)
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@angelocordero @victorsanni
allow changing textAlign of TextField in DropdownMenu (flutter#148074)
35355fa 
PR for flutter#147991
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
2fe0649 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
378c2ed 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
7b48269 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
706a96d 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
9b1b6cd 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
18e6b78 
…r/flutter#148074)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
29cf919 
…r/flutter#148074)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
6018b94 
…r/flutter#148074)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
82d9219 
…r/flutter#148074)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
c94f15d 
…r/flutter#148074)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
1d24aa2 
…r/flutter#148074)
@piedcipher piedcipher mentioned this pull request Jul 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
11cbe41 allow changing textAlign of TextField in DropdownMenu (flutte…
f8c99da 
…r/flutter#148074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes
@Piinks Piinks Piinks approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelocordero @justinmc @Piinks