Repository navigation
fix a regex in the ios logs command - #1481
Merged
Merged
Conversation
Contributor
|
Presumably this fixes #869 ? |
Contributor
There was a problem hiding this comment.
this is still going to be buggy. See the comment higher up. We should be properly buffering the text using a stream and a LineSplitter or something.
Contributor
Author
There was a problem hiding this comment.
Yup, good point. I changed to using a LineSplitter, filters, and listeners. Shorter and fewer bugs :)
Contributor
|
lgtm |
fixed sub-process stdout parsing; added todos
devoncarew
force-pushed
the
patch_ios_logs
branch
from
January 31, 2016 06:48
f96e44d to
d631ebe
Compare
Contributor
|
new code looks great |
devoncarew
added a commit
that referenced
this pull request
Jan 31, 2016
fix a regex in the ios logs command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startcommandlogscommandfix #869