Skip to content

Test raw autocomplete api examples - #148234

Merged
auto-submit[bot] merged 12 commits into
flutter:masterfrom
derdilla:130459-raw_autocomplete
May 23, 2024
Merged

auto-submit[bot] merged 12 commits into
flutter:masterfrom
derdilla:130459-raw_autocomplete

Conversation

@derdilla

Copy link
Copy Markdown
Contributor

Part of #130459.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels May 13, 2024
@goderbauer
goderbauer requested review from TahaTesser and bleroux May 14, 2024 22:10

@bleroux bleroux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits.
Thanks!

Comment thread examples/api/test/widgets/autocomplete/raw_autocomplete.1_test.dart Outdated

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

Comment thread examples/api/test/widgets/autocomplete/raw_autocomplete.focus_node.0_test.dart Outdated
Comment thread examples/api/test/widgets/autocomplete/raw_autocomplete.focus_node.0_test.dart Outdated
Comment thread examples/api/test/widgets/autocomplete/raw_autocomplete.focus_node.0_test.dart Outdated
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit

auto-submit Bot commented May 20, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148234, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TahaTesser

Copy link
Copy Markdown
Contributor

@NobodyForNothing
You might need to rebase to fix Google testing

@bleroux

bleroux commented May 21, 2024

Copy link
Copy Markdown
Contributor

@NobodyForNothing Can you rebase this PR?

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit
auto-submit Bot merged commit abad372 into flutter:master May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
flutter/flutter@73bf206...8d955cd

2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@73bf206...8d955cd

2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@73bf206...8d955cd

2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 [email protected] Roll Packages from 92f3c9a to 270131a (12 revisions) (flutter/flutter#148864)
2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants