Repository navigation
Add test for image.error_builder.0.dart API example. - #148497
Merged
auto-submit[bot] merged 2 commits intoMay 20, 2024
Merged
auto-submit[bot] merged 2 commits into
auto-submit[bot] merged 2 commits into
Conversation
ksokolovskyi
force-pushed
the
add-image-error-builder-example-tests
branch
from
May 20, 2024 10:00
a18e69a to
6a52c74
Compare
bleroux
approved these changes
May 20, 2024
bleroux
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
(Just one small nit to fix)
Contributor
There was a problem hiding this comment.
Suggested change
| testWidgets('has nonexistent url', (WidgetTester tester) async { | |
| testWidgets('Has nonexistent url', (WidgetTester tester) async { |
ksokolovskyi
force-pushed
the
add-image-error-builder-example-tests
branch
from
May 20, 2024 14:51
6a52c74 to
52c726a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2024
Contributor
Author
|
@TahaTesser @bleroux thanks a lot for the review! |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 20, 2024
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from c92003b to 92f3c9a (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contributes to #130459
Description
examples/api/lib/widgets/image/image.error_builder.0.dartPre-launch Checklist
///).