Skip to content

[a11y] Slider should respect bold text setting - #149053

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
hannah-hyj:fix147600-2
May 24, 2024
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
hannah-hyj:fix147600-2

Conversation

@hannah-hyj

Copy link
Copy Markdown
Member

Fix #147600

internal GAR issue: b/316933135

reopen from #148435

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hannah-hyj
hannah-hyj requested a review from TahaTesser May 24, 2024 18:31
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 24, 2024

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit
auto-submit Bot merged commit 8ff5709 into flutter:master May 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 25, 2024
flutter/flutter@8dd0831...cb26a01

2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070)
2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068)
2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057)
2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670)
2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055)
2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053)
2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874)
2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051)
2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872)
2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045)
2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298)
2024-05-24 [email protected] Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@8dd0831...cb26a01

2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070)
2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068)
2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057)
2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670)
2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055)
2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053)
2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874)
2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051)
2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872)
2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045)
2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298)
2024-05-24 [email protected] Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@8dd0831...cb26a01

2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070)
2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068)
2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057)
2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670)
2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055)
2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053)
2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874)
2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051)
2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872)
2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045)
2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298)
2024-05-24 [email protected] Roll Packages from 23a7353 to 1b74063 (2 revisions) (flutter/flutter#149043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y] Slider: Bold text setting not enhancing the slider screen text/controls size

2 participants