Repository navigation
closes #issue136763, changed a command to generate gradle error message according to platform - #149877
Conversation
github-actions
Bot
added
the
tool
240ae41 to
ed65b09
Compare
|
@christopherfujino sir please review it whenever you get time. |
89193a6 to
9eb2ecf
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Piinks please review it whenever is feasible for you. |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hi @D-extremity welcome, thanks for sending a PR. Unfortunately I am probably not the best person to review it. Perhaps @reidbaker?
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
Looks good thanks for your contribution. Some minor nits
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
packages/flutter_tools/lib/src/android/gradle_errors.dart test should not need to be modified.
…e according to platform added missing newline at end of the file added eod to fix linux analyze failure ci.validation failure test to pass canvaskti error fixed
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
reidbaker
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/149877, due to - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
fixed syntax error
|
@reidbaker please add auto submit label again as earlier cases were failed . |
reidbaker
added
the
autosubmit
…or message according to platform (flutter/flutter#149877)
…or message according to platform (flutter/flutter#149877)
…or message according to platform (flutter/flutter#149877)
…or message according to platform (flutter/flutter#149877)
…or message according to platform (flutter/flutter#149877)
…or message according to platform (flutter/flutter#149877)
…ge according to platform (flutter#149877) Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command. closes flutter#136763
…ge according to platform (flutter#149877) Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command. closes flutter#136763
…or message according to platform (flutter/flutter#149877)
4 participants
Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command.
closes #136763
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].