Skip to content

Add tests for navigator.0.dart - #150034

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-navigator-0
Jun 14, 2024
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-navigator-0

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Contributes to #130459

It adds a test for

  • examples/api/lib/widgets/navigator/navigator.0.dart

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels Jun 11, 2024
@ValentinVignal ValentinVignal changed the title tAdd tests for navigator.0.dart Add tests for navigator.0.dart Jun 12, 2024
@goderbauer
goderbauer requested review from TahaTesser and bleroux June 12, 2024 22:06

@bleroux bleroux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2024
@auto-submit
auto-submit Bot merged commit 349ec71 into flutter:master Jun 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 14, 2024
flutter/flutter@01db23b...349ec71

2024-06-14 [email protected] Add tests for navigator.0.dart (flutter/flutter#150034)
2024-06-14 [email protected] Switch to `Iterable.cast` instance method (flutter/flutter#150185)
2024-06-14 [email protected] Include transform in static Gradient lerp methods (flutter/flutter#149624)
2024-06-14 [email protected] Validate the `contrastLevel` during `ColorScheme` creation (flutter/flutter#150176)
2024-06-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.9 to 3.25.10 (flutter/flutter#150228)
2024-06-13 [email protected] Fix leaky test. (flutter/flutter#150235)
2024-06-13 [email protected] Document CIPD role & login for upgrading Android engine (flutter/flutter#149433)
2024-06-13 [email protected] Update doc for `ColorScheme.surface` (flutter/flutter#150212)
2024-06-13 [email protected] Roll pub packages (flutter/flutter#150206)
2024-06-13 [email protected] Bump new release for a11y_assessment (flutter/flutter#150213)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#149641)
2024-06-13 [email protected] Reland "Identify and re-throw our dependency checking errors in flutter.groovy" (flutter/flutter#150128)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#150180)
2024-06-13 [email protected] Suppress Flutter update check if `--machine` is present at all. (flutter/flutter#150138)
2024-06-13 [email protected] [Reland] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149876)
2024-06-13 [email protected] Update framework and flutter fix flutter.dev/docs links (flutter/flutter#150174)
2024-06-13 [email protected] Roll Flutter Engine from 4cb3025d3abf to 8167dffd1914 (2 revisions) (flutter/flutter#150208)
2024-06-13 [email protected] Replace InputDecorator M3 golden test (flutter/flutter#150111)
2024-06-13 [email protected] Roll Packages from 260102b to 7805455 (2 revisions) (flutter/flutter#150198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
Contributes to flutter#130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator.0.dart`
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
Contributes to flutter#130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator.0.dart`
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@01db23b...349ec71

2024-06-14 [email protected] Add tests for navigator.0.dart (flutter/flutter#150034)
2024-06-14 [email protected] Switch to `Iterable.cast` instance method (flutter/flutter#150185)
2024-06-14 [email protected] Include transform in static Gradient lerp methods (flutter/flutter#149624)
2024-06-14 [email protected] Validate the `contrastLevel` during `ColorScheme` creation (flutter/flutter#150176)
2024-06-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.9 to 3.25.10 (flutter/flutter#150228)
2024-06-13 [email protected] Fix leaky test. (flutter/flutter#150235)
2024-06-13 [email protected] Document CIPD role & login for upgrading Android engine (flutter/flutter#149433)
2024-06-13 [email protected] Update doc for `ColorScheme.surface` (flutter/flutter#150212)
2024-06-13 [email protected] Roll pub packages (flutter/flutter#150206)
2024-06-13 [email protected] Bump new release for a11y_assessment (flutter/flutter#150213)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#149641)
2024-06-13 [email protected] Reland "Identify and re-throw our dependency checking errors in flutter.groovy" (flutter/flutter#150128)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#150180)
2024-06-13 [email protected] Suppress Flutter update check if `--machine` is present at all. (flutter/flutter#150138)
2024-06-13 [email protected] [Reland] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149876)
2024-06-13 [email protected] Update framework and flutter fix flutter.dev/docs links (flutter/flutter#150174)
2024-06-13 [email protected] Roll Flutter Engine from 4cb3025d3abf to 8167dffd1914 (2 revisions) (flutter/flutter#150208)
2024-06-13 [email protected] Replace InputDecorator M3 golden test (flutter/flutter#150111)
2024-06-13 [email protected] Roll Packages from 260102b to 7805455 (2 revisions) (flutter/flutter#150198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@01db23b...349ec71

2024-06-14 [email protected] Add tests for navigator.0.dart (flutter/flutter#150034)
2024-06-14 [email protected] Switch to `Iterable.cast` instance method (flutter/flutter#150185)
2024-06-14 [email protected] Include transform in static Gradient lerp methods (flutter/flutter#149624)
2024-06-14 [email protected] Validate the `contrastLevel` during `ColorScheme` creation (flutter/flutter#150176)
2024-06-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.9 to 3.25.10 (flutter/flutter#150228)
2024-06-13 [email protected] Fix leaky test. (flutter/flutter#150235)
2024-06-13 [email protected] Document CIPD role & login for upgrading Android engine (flutter/flutter#149433)
2024-06-13 [email protected] Update doc for `ColorScheme.surface` (flutter/flutter#150212)
2024-06-13 [email protected] Roll pub packages (flutter/flutter#150206)
2024-06-13 [email protected] Bump new release for a11y_assessment (flutter/flutter#150213)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#149641)
2024-06-13 [email protected] Reland "Identify and re-throw our dependency checking errors in flutter.groovy" (flutter/flutter#150128)
2024-06-13 [email protected] Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#150180)
2024-06-13 [email protected] Suppress Flutter update check if `--machine` is present at all. (flutter/flutter#150138)
2024-06-13 [email protected] [Reland] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149876)
2024-06-13 [email protected] Update framework and flutter fix flutter.dev/docs links (flutter/flutter#150174)
2024-06-13 [email protected] Roll Flutter Engine from 4cb3025d3abf to 8167dffd1914 (2 revisions) (flutter/flutter#150208)
2024-06-13 [email protected] Replace InputDecorator M3 golden test (flutter/flutter#150111)
2024-06-13 [email protected] Roll Packages from c6a6442 to a28935e (2 revisions) (flutter/flutter#150198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants