Add test for segmented_button.0.dart by ValentinVignal · Pull Request #150676 · flutter/flutter

ValentinVignal · 2024-06-24T03:40:07Z

Contributes to #130459

It adds a test for

examples/api/test/material/segmented_button/segmented_button.0_test.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

LGTM with nits.

bleroux · 2024-06-26T07:33:42Z

+    await tester.pumpWidget(
+      const example.SegmentedButtonApp(),
+    );
+


Not sure it will be more readable, maybe use a helper to avoid repeating the verbose expect?

Suggested change

void expectOneCalendarButton(example.Calendar period) {

expect(

find.byWidgetPredicate(

(Widget widget) => widget is SegmentedButton<example.Calendar> && setEquals(widget.selected, <example.Calendar>{period}),

),

findsOne,

);

}

bleroux · 2024-06-26T07:33:57Z

+    expect(find.byWidgetPredicate(
+      (Widget widget) => widget is SegmentedButton<example.Calendar> && setEquals(widget.selected, const <example.Calendar>{example.Calendar.day}),
+    ), findsOne);
+


Remove extra line

bleroux · 2024-06-26T07:34:25Z

+
+  });
+
+  testWidgets('Segmented button can be used for with a multiple selection', (WidgetTester tester) async {


Typo 'for with'

bleroux · 2024-06-26T07:34:59Z

+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+  testWidgets('Segmented button can be used for with a single selection', (WidgetTester tester) async {


typo 'for with'

ValentinVignal · 2024-06-26T15:36:17Z

Thank you for the review @bleroux, everything should be fixed in refactor: Use helper

TahaTesser

LGTM

flutter/flutter@651a17d...99bb2ff 2024-07-01 [email protected] Roll Flutter Engine from 0d93da7e2fe1 to b57a044ed10f (1 revision) (flutter/flutter#151082) 2024-06-30 [email protected] Roll Flutter Engine from ad1343cfb99e to 0d93da7e2fe1 (9 revisions) (flutter/flutter#151062) 2024-06-29 [email protected] Reduce the depth used in a test that applies finders to deep widget trees (flutter/flutter#151049) 2024-06-29 [email protected] Roll Flutter Engine from f828363d03ff to ad1343cfb99e (3 revisions) (flutter/flutter#151016) 2024-06-29 [email protected] Add test for segmented_button.0.dart (flutter/flutter#150676) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#151022) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#150827) 2024-06-28 [email protected] Roll Flutter Engine from 2f7e9ab27493 to f828363d03ff (3 revisions) (flutter/flutter#151013) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.11 (flutter/flutter#151012) 2024-06-28 [email protected] [tool] when writing to openssl as a part of macOS/iOS code-signing, flush the stdin stream before closing it (flutter/flutter#150120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Contributes to flutter#130459 It adds a test for - `examples/api/test/material/segmented_button/segmented_button.0_test.dart`

flutter/flutter@651a17d...99bb2ff 2024-07-01 [email protected] Roll Flutter Engine from 0d93da7e2fe1 to b57a044ed10f (1 revision) (flutter/flutter#151082) 2024-06-30 [email protected] Roll Flutter Engine from ad1343cfb99e to 0d93da7e2fe1 (9 revisions) (flutter/flutter#151062) 2024-06-29 [email protected] Reduce the depth used in a test that applies finders to deep widget trees (flutter/flutter#151049) 2024-06-29 [email protected] Roll Flutter Engine from f828363d03ff to ad1343cfb99e (3 revisions) (flutter/flutter#151016) 2024-06-29 [email protected] Add test for segmented_button.0.dart (flutter/flutter#150676) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#151022) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#150827) 2024-06-28 [email protected] Roll Flutter Engine from 2f7e9ab27493 to f828363d03ff (3 revisions) (flutter/flutter#151013) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.11 (flutter/flutter#151012) 2024-06-28 [email protected] [tool] when writing to openssl as a part of macOS/iOS code-signing, flush the stdin stream before closing it (flutter/flutter#150120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

test: Add test for segmented_button.0.dart

49d49b0

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 24, 2024

goderbauer requested review from TahaTesser and bleroux June 25, 2024 22:06

bleroux approved these changes Jun 26, 2024

View reviewed changes

refactor: Use helper

397f49d

TahaTesser approved these changes Jun 28, 2024

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2024

auto-submit Bot merged commit 96c5577 into flutter:master Jun 29, 2024

engine-flutter-autoroll mentioned this pull request Jun 29, 2024

Roll Flutter from 651a17db5427 to e1feb723b9dc (7 revisions) flutter/packages#7016

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2024

96c5577 Add test for segmented_button.0.dart (flutter/flutter#150676)

bea17fd

engine-flutter-autoroll mentioned this pull request Jun 29, 2024

Roll Flutter from 651a17db5427 to e1feb723b9dc (7 revisions) flutter/packages#7017

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2024

96c5577 Add test for segmented_button.0.dart (flutter/flutter#150676)

732bbec

engine-flutter-autoroll mentioned this pull request Jun 30, 2024

Roll Flutter from 651a17db5427 to 1c9c375e4e33 (9 revisions) flutter/packages#7019

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2024

96c5577 Add test for segmented_button.0.dart (flutter/flutter#150676)

5e96808

engine-flutter-autoroll mentioned this pull request Jul 1, 2024

Roll Flutter from 651a17db5427 to 99bb2ff6a614 (10 revisions) flutter/packages#7038

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2024

96c5577 Add test for segmented_button.0.dart (flutter/flutter#150676)

1eabc55

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024

Add test for segmented_button.0.dart (flutter#150676)

4a06620

Contributes to flutter#130459 It adds a test for - `examples/api/test/material/segmented_button/segmented_button.0_test.dart`

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

96c5577 Add test for segmented_button.0.dart (flutter/flutter#150676)

4e4e6cc

Navigation Menu

Repository navigation

Add test for segmented_button.0.dart - #150676

Add test for segmented_button.0.dart#150676
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-segmented-button

ValentinVignal commented Jun 24, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Jun 26, 2024

Uh oh!

bleroux Jun 26, 2024

Uh oh!

bleroux Jun 26, 2024

Uh oh!

bleroux Jun 26, 2024

Uh oh!

ValentinVignal commented Jun 26, 2024

Uh oh!

TahaTesser left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+    void expectOneCalendarButton(example.Calendar period) {
+      expect(
+        find.byWidgetPredicate(
+          (Widget widget) => widget is SegmentedButton<example.Calendar> && setEquals(widget.selected, <example.Calendar>{period}),
+        ),
+        findsOne,
+      );
+    }


		});

		testWidgets('Segmented button can be used for with a multiple selection', (WidgetTester tester) async {

Conversation

ValentinVignal commented Jun 24, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Jun 26, 2024

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants