Make the App's title optional on web by tugorez · Pull Request #152003 · flutter/flutter

tugorez · 2024-07-18T22:52:47Z

Title (in web) results in updating the title element which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

tugorez · 2024-07-25T22:22:02Z

@yjbanov @Piinks do you happen to know why not instantiating the Title widget leads to Navigator not being found in https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/app_overrides_test.dart#L79?

Piinks · 2024-07-31T18:13:23Z

do you happen to know why not instantiating the Title widget leads to Navigator not being found

I do not, maybe @chunhtai has some context?

chunhtai

LGTM

auto-submit · 2024-08-02T16:47:20Z

auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux_android_emu android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-08-02T17:22:09Z

auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-08-02T17:55:07Z

auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux web_skwasm_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

Manual roll requested by [email protected] flutter/flutter@f10a497...cbfb222 2024-08-04 [email protected] Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) (flutter/flutter#152824) 2024-08-03 [email protected] Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) (flutter/flutter#152821) 2024-08-03 [email protected] Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) (flutter/flutter#152818) 2024-08-03 [email protected] Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) (flutter/flutter#152814) 2024-08-03 [email protected] Fix device_os requested in linux_build_test tests (flutter/flutter#152808) 2024-08-03 [email protected] Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) (flutter/flutter#152804) 2024-08-03 [email protected] Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (flutter/flutter#152796) 2024-08-03 [email protected] Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) (flutter/flutter#152790) 2024-08-03 [email protected] Improve `CupertinoRadio` fidelity (flutter/flutter#149703) 2024-08-03 [email protected] Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) (flutter/flutter#152777) 2024-08-02 [email protected] Fix handling of `iconSize` and `iconColor` defaults for `ButtonStyleButton` subclasses. (flutter/flutter#143501) 2024-08-02 [email protected] Use print logging on LUCI. (flutter/flutter#152776) 2024-08-02 [email protected] Reland: Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152756) 2024-08-02 [email protected] Write more on Animation and related docs (flutter/flutter#150727) 2024-08-02 [email protected] Quick Grammar Fixes (flutter/flutter#152744) 2024-08-02 [email protected] Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) (flutter/flutter#152762) 2024-08-02 [email protected] [SliderTheme] Fix markdown links for api doc images (flutter/flutter#152748) 2024-08-02 [email protected] Make the App's title optional on web (flutter/flutter#152003) 2024-08-02 [email protected] Add tests for scaffold messenger state (flutter/flutter#152735) 2024-08-02 [email protected] Ignore both unused_element and unused_element_parameter (flutter/flutter#152689) 2024-08-02 [email protected] Update dartdoc to 8.0.12 to fix focusing search field (flutter/flutter#151576) 2024-08-02 [email protected] [wiki] Remove outdated warning about stale coverage data (flutter/flutter#152560) 2024-08-02 [email protected] Roll Packages from 27896d1 to cc9ff47 (8 revisions) (flutter/flutter#152754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Title (in web) results in updating the [title element][1] which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.

) Manual roll requested by [email protected] flutter/flutter@f10a497...cbfb222 2024-08-04 [email protected] Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) (flutter/flutter#152824) 2024-08-03 [email protected] Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) (flutter/flutter#152821) 2024-08-03 [email protected] Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) (flutter/flutter#152818) 2024-08-03 [email protected] Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) (flutter/flutter#152814) 2024-08-03 [email protected] Fix device_os requested in linux_build_test tests (flutter/flutter#152808) 2024-08-03 [email protected] Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) (flutter/flutter#152804) 2024-08-03 [email protected] Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (flutter/flutter#152796) 2024-08-03 [email protected] Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) (flutter/flutter#152790) 2024-08-03 [email protected] Improve `CupertinoRadio` fidelity (flutter/flutter#149703) 2024-08-03 [email protected] Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) (flutter/flutter#152777) 2024-08-02 [email protected] Fix handling of `iconSize` and `iconColor` defaults for `ButtonStyleButton` subclasses. (flutter/flutter#143501) 2024-08-02 [email protected] Use print logging on LUCI. (flutter/flutter#152776) 2024-08-02 [email protected] Reland: Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152756) 2024-08-02 [email protected] Write more on Animation and related docs (flutter/flutter#150727) 2024-08-02 [email protected] Quick Grammar Fixes (flutter/flutter#152744) 2024-08-02 [email protected] Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) (flutter/flutter#152762) 2024-08-02 [email protected] [SliderTheme] Fix markdown links for api doc images (flutter/flutter#152748) 2024-08-02 [email protected] Make the App's title optional on web (flutter/flutter#152003) 2024-08-02 [email protected] Add tests for scaffold messenger state (flutter/flutter#152735) 2024-08-02 [email protected] Ignore both unused_element and unused_element_parameter (flutter/flutter#152689) 2024-08-02 [email protected] Update dartdoc to 8.0.12 to fix focusing search field (flutter/flutter#151576) 2024-08-02 [email protected] [wiki] Remove outdated warning about stale coverage data (flutter/flutter#152560) 2024-08-02 [email protected] Roll Packages from 27896d1 to cc9ff47 (8 revisions) (flutter/flutter#152754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by [email protected] flutter/flutter@f10a497...cbfb222 2024-08-04 [email protected] Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) (flutter/flutter#152824) 2024-08-03 [email protected] Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) (flutter/flutter#152821) 2024-08-03 [email protected] Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) (flutter/flutter#152818) 2024-08-03 [email protected] Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) (flutter/flutter#152814) 2024-08-03 [email protected] Fix device_os requested in linux_build_test tests (flutter/flutter#152808) 2024-08-03 [email protected] Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) (flutter/flutter#152804) 2024-08-03 [email protected] Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (flutter/flutter#152796) 2024-08-03 [email protected] Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) (flutter/flutter#152790) 2024-08-03 [email protected] Improve `CupertinoRadio` fidelity (flutter/flutter#149703) 2024-08-03 [email protected] Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) (flutter/flutter#152777) 2024-08-02 [email protected] Fix handling of `iconSize` and `iconColor` defaults for `ButtonStyleButton` subclasses. (flutter/flutter#143501) 2024-08-02 [email protected] Use print logging on LUCI. (flutter/flutter#152776) 2024-08-02 [email protected] Reland: Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152756) 2024-08-02 [email protected] Write more on Animation and related docs (flutter/flutter#150727) 2024-08-02 [email protected] Quick Grammar Fixes (flutter/flutter#152744) 2024-08-02 [email protected] Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) (flutter/flutter#152762) 2024-08-02 [email protected] [SliderTheme] Fix markdown links for api doc images (flutter/flutter#152748) 2024-08-02 [email protected] Make the App's title optional on web (flutter/flutter#152003) 2024-08-02 [email protected] Add tests for scaffold messenger state (flutter/flutter#152735) 2024-08-02 [email protected] Ignore both unused_element and unused_element_parameter (flutter/flutter#152689) 2024-08-02 [email protected] Update dartdoc to 8.0.12 to fix focusing search field (flutter/flutter#151576) 2024-08-02 [email protected] [wiki] Remove outdated warning about stale coverage data (flutter/flutter#152560) 2024-08-02 [email protected] Roll Packages from bdcbf83 to a008277 (8 revisions) (flutter/flutter#152754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

MaterialApp's title defaults to '', and with any non-null title WidgetsApp mounts a Title widget whose value the web engine writes into document.title. With title: null, WidgetsApp skips Title on the web — the host page owns the title (flutter/flutter#152003). The JS guards on document.title from the previous commit are gone. Co-Authored-By: Claude Fable 5.1 <[email protected]>

* Keep the page title when a Flutter island starts Every island is a MaterialApp, and MaterialApp renders a Title widget with an empty title; the web engine forwards that to document.title, so the tab showed the address instead of the page title as soon as a demo attached — on the landing page and on every docs page with an example. Both runtimes now ignore writes of an empty document.title before the engine loads; the titles Next sets on navigation still go through. Verified in headless Chrome on /, /docs/first-form and across client- side navigation between docs pages. Co-Authored-By: Claude Fable 5.1 <[email protected]> * Fix the page title at the source: no Title widget in the islands MaterialApp's title defaults to '', and with any non-null title WidgetsApp mounts a Title widget whose value the web engine writes into document.title. With title: null, WidgetsApp skips Title on the web — the host page owns the title (flutter/flutter#152003). The JS guards on document.title from the previous commit are gone. Co-Authored-By: Claude Fable 5.1 <[email protected]> * Shorter comment on the null title Co-Authored-By: Claude Fable 5.1 <[email protected]> --------- Co-authored-by: Claude Fable 5.1 <[email protected]>

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages labels Jul 18, 2024

tugorez marked this pull request as ready for review July 18, 2024 23:01

tugorez requested review from goderbauer and yjbanov July 18, 2024 23:01

tugorez changed the title ~~Make the App's title optional~~ Make the App's title as optional Jul 19, 2024

tugorez changed the title ~~Make the App's title as optional~~ Make the App's title optional Jul 19, 2024

goderbauer reviewed Jul 19, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/title.dart Outdated

Comment thread packages/flutter/lib/src/widgets/app.dart

Comment thread packages/flutter/lib/src/material/app.dart

tugorez changed the title ~~Make the App's title optional~~ Make the App's title optional on web Jul 23, 2024

tugorez requested a review from goderbauer July 23, 2024 22:09

reidbaker approved these changes Jul 24, 2024

View reviewed changes

tugorez requested a review from Piinks July 25, 2024 22:22

chunhtai reviewed Jul 31, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/app.dart

tugorez requested a review from chunhtai August 2, 2024 16:32

chunhtai approved these changes Aug 2, 2024

View reviewed changes

tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

tugorez added 3 commits August 2, 2024 12:01

Make the title optional

56dcb8d

Apply reviewers feedback

1f04107

Make the title changes web only

a0f4e0e

tugorez added 7 commits August 2, 2024 12:01

Fix typo

4e5f6d3

Assign result to title

1ad7c82

Add a comment

3eca4d2

Add skip tests justification

5e86746

Fix test

7cae077

Refactor test

0fae5c8

Fix test

7e0e3a8

tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024

auto-submit Bot merged commit af834ee into flutter:master Aug 2, 2024

tugorez deleted the title branch August 2, 2024 20:03

engine-flutter-autoroll mentioned this pull request Aug 4, 2024

Manual roll Flutter from f10a497e4abd to cbfb22244697 (23 revisions) flutter/packages#7298

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2024

af834ee Make the App's title optional on web (flutter/flutter#152003)

23426d5

engine-flutter-autoroll mentioned this pull request Aug 4, 2024

Roll Flutter from f10a497e4abd to cbfb22244697 (23 revisions) flutter/packages#7299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2024

af834ee Make the App's title optional on web (flutter/flutter#152003)

34c553d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

af834ee Make the App's title optional on web (flutter/flutter#152003)

6477cc0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

af834ee Make the App's title optional on web (flutter/flutter#152003)

22fdeb0

Navigation Menu

Repository navigation

Make the App's title optional on web - #152003

Make the App's title optional on web#152003
auto-submit[bot] merged 10 commits into
flutter:masterfrom
tugorez:title

tugorez commented Jul 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tugorez commented Jul 25, 2024 •

edited

Loading

Uh oh!

Piinks commented Jul 31, 2024

Uh oh!

Uh oh!

chunhtai left a comment

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tugorez commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tugorez commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks commented Jul 31, 2024

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

auto-submit Bot commented Aug 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tugorez commented Jul 18, 2024 •

edited

Loading

tugorez commented Jul 25, 2024 •

edited

Loading