Skip to content

[web] Pass --no-source-maps instead of --extra-compiler-option=--no-source-maps to dart compile wasm - #153417

Merged
mkustermann merged 1 commit into
flutter:masterfrom
mkustermann:source-map-option
Aug 14, 2024
Merged

[web] Pass --no-source-maps instead of --extra-compiler-option=--no-source-maps to dart compile wasm#153417
mkustermann merged 1 commit into
flutter:masterfrom
mkustermann:source-map-option

Conversation

@mkustermann

@mkustermann mkustermann commented Aug 14, 2024

Copy link
Copy Markdown
Member

No description provided.

@mkustermann
mkustermann requested a review from osa1 August 14, 2024 08:34
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 14, 2024
@mkustermann
mkustermann merged commit 354902f into flutter:master Aug 14, 2024
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 14, 2024
@mkustermann Commit Queue
[dart2wasm] Simplify source map flag code in dart compile wasm
07da83d 
After [0] lands we can remove a workaround in `dart compile wasm` that
checks for `--extra-compiler-option=--no-source-maps`.

[0] flutter/flutter#153417

Change-Id: I19f4da96e198d73e2309652aa2aa08d5e2c72d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380461
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
1d6b0c6 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
c984f78 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
78a22d1 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
c813fb0 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
8a57549 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
de68d24 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
62a1e07 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 15, 2024
@engine-flutter-autoroll
Roll Flutter from cc13cd1 to 99f00a1 (24 revisions) (#7419)
4fb1db0 
flutter/flutter@cc13cd1...99f00a1

2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487)
2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385)
2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468)
2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464)
2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465)
2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463)
2024-08-14 [email protected] Lint sync (flutter/flutter#153453)
2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403)
2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601)
2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400)
2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960)
2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353)
2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368)
2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381)
2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436)
2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413)
2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134)
2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394)
2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395)
2024-08-13 [email protected] Roll Packages from d9a6de8 to e4f2247 (4 revisions) (flutter/flutter#153383)
2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380)
2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
@mkustermann @DBowen33
[web] Pass --no-source-maps instead of `--extra-compiler-option=--n…
1480d14 
…o-source-maps` to `dart compile wasm` (flutter#153417)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@mkustermann @Buchimi
[web] Pass --no-source-maps instead of `--extra-compiler-option=--n…
0d3d661 
…o-source-maps` to `dart compile wasm` (flutter#153417)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
838c2c4 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
354902f [web] Pass --no-source-maps instead of `--extra-compiler-op…
e24ca00 
…tion=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from cc13cd1 to 99f00a1 (24 revisions) (flutter#7419)
421ceac 
flutter/flutter@cc13cd1...99f00a1

2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487)
2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385)
2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468)
2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464)
2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465)
2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463)
2024-08-14 [email protected] Lint sync (flutter/flutter#153453)
2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403)
2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601)
2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400)
2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960)
2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353)
2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368)
2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381)
2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436)
2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413)
2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134)
2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394)
2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395)
2024-08-13 [email protected] Roll Packages from d9a6de8 to e4f2247 (4 revisions) (flutter/flutter#153383)
2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380)
2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from cc13cd1 to 99f00a1 (24 revisions) (flutter#7419)
f49406d 
flutter/flutter@cc13cd1...99f00a1

2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487)
2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385)
2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468)
2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464)
2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465)
2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463)
2024-08-14 [email protected] Lint sync (flutter/flutter#153453)
2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403)
2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601)
2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400)
2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960)
2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353)
2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368)
2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381)
2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436)
2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417)
2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413)
2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134)
2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394)
2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395)
2024-08-13 [email protected] Roll Packages from 0f432a9 to d91e0fc (4 revisions) (flutter/flutter#153383)
2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380)
2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@osa1 osa1 osa1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkustermann @osa1