Skip to content

fixed keyboardDismissBehavior on scroll without a drag - #154675

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
nick9822:fix_keyboardDismissBehavior_on_scroll_without_a_drag
Sep 24, 2024
Merged

fixed keyboardDismissBehavior on scroll without a drag#154675
auto-submit[bot] merged 3 commits into
flutter:masterfrom
nick9822:fix_keyboardDismissBehavior_on_scroll_without_a_drag

Conversation

@nick9822

@nick9822 nick9822 commented Sep 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #154515, #150048 and other similar issues where user non-draggable scrolls (mouse wheel, two-fingers) should behave same as draggable ones.

In this PR, scrollUpdateNotification.dragDetails check is removed and it has a supporting test which simulates a scroll which does not produce a drag.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Sep 5, 2024
@nick9822
nick9822 force-pushed the fix_keyboardDismissBehavior_on_scroll_without_a_drag branch from aca498c to ca0f3d2 Compare September 5, 2024 16:56
@goderbauer

goderbauer commented Sep 10, 2024

Copy link
Copy Markdown
Member

(triage): Could you please take a look at the analyzer check and fix what it is complaining about? Thank you!

@goderbauer
goderbauer requested a review from Piinks September 10, 2024 22:18
@nick9822

nick9822 commented Sep 11, 2024

Copy link
Copy Markdown
Contributor Author

@goderbauer fixed it, now Linux analyze is passing. But Windows build_tests_6_7 is failing but doesn't seem to be related to the newline commit.

@Piinks
Piinks requested a review from victorsanni September 11, 2024 19:55
victorsanni
victorsanni reviewed Sep 14, 2024
View reviewed changes
Comment thread packages/flutter/lib/src/widgets/single_child_scroll_view.dart
victorsanni
victorsanni approved these changes Sep 24, 2024
View reviewed changes

@victorsanni victorsanni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is identical to #150317. While that PR was created earlier, the author of that PR has not responded in a while, and we'd like to go forward with this change (as per the conversation in the other PR).

cc @justinmc

victorsanni
victorsanni requested changes Sep 24, 2024
View reviewed changes

@victorsanni victorsanni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending formatting nits.

Comment thread packages/flutter/test/widgets/single_child_scroll_view_test.dart Outdated
Comment thread packages/flutter/test/widgets/single_child_scroll_view_test.dart Outdated
Comment thread packages/flutter/test/widgets/single_child_scroll_view_test.dart Outdated
@victorsanni victorsanni mentioned this pull request Sep 24, 2024
Closed
9 tasks done
@nick9822

nick9822 commented Sep 24, 2024

Copy link
Copy Markdown
Contributor Author

@victorsanni did the formatting changes as suggested.

Piinks
Piinks approved these changes Sep 24, 2024
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2024
@auto-submit
auto-submit Bot merged commit d95821c into flutter:master Sep 24, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
5aacd48 
…er/flutter#154675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
69b0108 
…er/flutter#154675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
7625823 
…er/flutter#154675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
73f0ae7 
…er/flutter#154675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
50d11a6 
…er/flutter#154675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
9be23fa 
…er/flutter#154675)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 25, 2024
@engine-flutter-autoroll
Roll Flutter from 4ca51a1 to 538e742 (40 revisions) (#7705)
18f1dfd 
Roll Flutter from 4ca51a1 to 538e742 (40 revisions)

flutter/flutter@4ca51a1...538e742

2024-09-25 [email protected] Marks Linux build_aar_module_test to be unflaky (flutter/flutter#155349)
2024-09-25 [email protected] Roll Packages from 4926c0f to 7da2374 (3 revisions) (flutter/flutter#155701)
2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Normalize TabBarTheme (#155476)" (flutter/flutter#155698)
2024-09-25 [email protected] Normalize TabBarTheme (flutter/flutter#155476)
2024-09-25 [email protected] increase both linux & windows tool integration test shards (flutter/flutter#155631)
2024-09-25 [email protected] Roll Flutter Engine from c7cd559e483b to d6d5fdba6ae1 (1 revision) (flutter/flutter#155693)
2024-09-25 [email protected] Add WidgetStateBorderSide example and tests for it. (flutter/flutter#155559)
2024-09-25 [email protected] Roll Flutter Engine from b9dd7a39dd58 to c7cd559e483b (1 revision) (flutter/flutter#155686)
2024-09-25 [email protected] Roll Flutter Engine from 87c1667dfd1e to b9dd7a39dd58 (1 revision) (flutter/flutter#155684)
2024-09-25 [email protected] Roll Flutter Engine from 05211f9d2267 to 87c1667dfd1e (1 revision) (flutter/flutter#155681)
2024-09-25 [email protected] Roll Flutter Engine from 8d1eb7410b49 to 05211f9d2267 (1 revision) (flutter/flutter#155672)
2024-09-25 [email protected] Roll Flutter Engine from ad3dd0df0fe7 to 8d1eb7410b49 (2 revisions) (flutter/flutter#155662)
2024-09-25 [email protected] Roll Flutter Engine from 746ce6124844 to ad3dd0df0fe7 (2 revisions) (flutter/flutter#155653)
2024-09-25 [email protected] Add PrivacyInfo.xcprivacy to macOS plugin template (flutter/flutter#155570)
2024-09-25 [email protected] Roll Flutter Engine from 559f2ff31c74 to 746ce6124844 (14 revisions) (flutter/flutter#155648)
2024-09-25 [email protected] fix `SearchAnchor` disposing `SearchController` while it is still used (flutter/flutter#155219)
2024-09-25 [email protected] Roll pub packages (flutter/flutter#155640)
2024-09-24 [email protected] Preserve transform when using *Gradient:withOpacity (flutter/flutter#154908)
2024-09-24 [email protected] fixed keyboardDismissBehavior on scroll without a drag (flutter/flutter#154675)
2024-09-24 [email protected] Roll Flutter Engine from 7cd3d0b1bb2e to 559f2ff31c74 (3 revisions) (flutter/flutter#155629)
2024-09-24 [email protected] Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (flutter/flutter#155625)
2024-09-24 [email protected] Misc docs cleanup and fixes (flutter/flutter#155501)
2024-09-24 [email protected] Roll Flutter Engine from dc44f95b7027 to 2a13c3a27e1f (1 revision) (flutter/flutter#155619)
2024-09-24 [email protected] Roll Flutter Engine from 2745b8797025 to dc44f95b7027 (1 revision) (flutter/flutter#155616)
2024-09-24 [email protected] Roll Flutter Engine from 8a54cc56d4b9 to 2745b8797025 (2 revisions) (flutter/flutter#155610)
2024-09-24 [email protected] Roll Flutter Engine from c07812775255 to 8a54cc56d4b9 (2 revisions) (flutter/flutter#155607)
2024-09-24 [email protected] Roll Packages from 9de72be to 4926c0f (4 revisions) (flutter/flutter#155605)
2024-09-24 [email protected] Fix some broken links in DAP readme (flutter/flutter#155600)
2024-09-24 [email protected] Roll Flutter Engine from 22e4f015cc99 to c07812775255 (2 revisions) (flutter/flutter#155599)
2024-09-24 [email protected] [flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (flutter/flutter#155249)
2024-09-24 [email protected] Roll Flutter Engine from 309468cfd1bb to 22e4f015cc99 (2 revisions) (flutter/flutter#155591)
2024-09-24 [email protected] [native assets] Roll dependencies (flutter/flutter#155432)
2024-09-24 [email protected] Roll Flutter Engine from 4013dc28a48b to 309468cfd1bb (2 revisions) (flutter/flutter#155588)
2024-09-24 [email protected] Roll Flutter Engine from 8a5af19a43f3 to 4013dc28a48b (1 revision) (flutter/flutter#155585)
2024-09-24 [email protected] Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) (flutter/flutter#155583)
2024-09-24 [email protected] Add `WidgetStateProperty` example and tests for it. (flutter/flutter#155315)
2024-09-24 [email protected] Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (flutter/flutter#155579)
2024-09-23 [email protected] Roll Flutter Engine from 61f0a3fbabbe to 9bb0ece79ae2 (2 revisions) (flutter/flutter#155549)
2024-09-23 [email protected] Assert macOS framework artifact contains xcprivacy manifest (flutter/flutter#155189)
2024-09-23 [email protected] Roll Packages from f54fe93 to 9de72be (1 revision) (flutter/flutter#155540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
@nick9822 @thejitenpatel
fixed keyboardDismissBehavior on scroll without a drag (flutter#154675)
5626641 
fixes flutter#154515, flutter#150048 and other similar issues where user non-draggable scrolls (mouse wheel, two-fingers) should behave same as draggable ones.

In this PR, scrollUpdateNotification.dragDetails check is removed and it has a supporting test which simulates a scroll which does not produce a drag.
@Piinks Piinks mentioned this pull request Sep 27, 2024
Closed
@victorsanni victorsanni mentioned this pull request Oct 6, 2024
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
3846dca 
…er/flutter#154675)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
d95821c fixed keyboardDismissBehavior on scroll without a drag (flutt…
3326f6f 
…er/flutter#154675)
@priyankabambharoliya-official

priyankabambharoliya-official commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown

After this update, the issue occurs when we use keyboard dismiss behaviour on drag
keyboardDismissBehavior: ScrollViewKeyboardDismissBehavior.onDrag

how to fix this issue?

see this video

Screen.Recording.2024-12-16.at.11.04.09.AM.mov

@priyankabambharoliya-official priyankabambharoliya-official mentioned this pull request Dec 16, 2024
Closed
@nick9822
nick9822 deleted the fix_keyboardDismissBehavior_on_scroll_without_a_drag branch December 16, 2024 12:45
@nick9822 nick9822 mentioned this pull request Dec 18, 2024
Closed
9 tasks done
This was referenced Jan 8, 2025
Merged
Closed
github-merge-queue Bot pushed a commit that referenced this pull request Jan 8, 2025
@victorsanni
Revert "fixed keyboardDismissBehavior on scroll without a drag" (#161277
9d7f6cc 
)

Reverts #154675 as it regresses
`ScrollViewKeyboardDismissBehavior.onDrag`.

Fixes #160331
srujzs pushed a commit to srujzs/flutter that referenced this pull request Jan 12, 2025
@victorsanni @srujzs
Revert "fixed keyboardDismissBehavior on scroll without a drag" (flut…
53abba9 
…ter#161277)

Reverts flutter#154675 as it regresses
`ScrollViewKeyboardDismissBehavior.onDrag`.

Fixes flutter#160331
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 4ca51a1 to 538e742 (40 revisions) (flutter#7705)
870b885 
Roll Flutter from 4ca51a1 to 538e742 (40 revisions)

flutter/flutter@4ca51a1...538e742

2024-09-25 [email protected] Marks Linux build_aar_module_test to be unflaky (flutter/flutter#155349)
2024-09-25 [email protected] Roll Packages from 4926c0f to 7da2374 (3 revisions) (flutter/flutter#155701)
2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Normalize TabBarTheme (#155476)" (flutter/flutter#155698)
2024-09-25 [email protected] Normalize TabBarTheme (flutter/flutter#155476)
2024-09-25 [email protected] increase both linux & windows tool integration test shards (flutter/flutter#155631)
2024-09-25 [email protected] Roll Flutter Engine from c7cd559e483b to d6d5fdba6ae1 (1 revision) (flutter/flutter#155693)
2024-09-25 [email protected] Add WidgetStateBorderSide example and tests for it. (flutter/flutter#155559)
2024-09-25 [email protected] Roll Flutter Engine from b9dd7a39dd58 to c7cd559e483b (1 revision) (flutter/flutter#155686)
2024-09-25 [email protected] Roll Flutter Engine from 87c1667dfd1e to b9dd7a39dd58 (1 revision) (flutter/flutter#155684)
2024-09-25 [email protected] Roll Flutter Engine from 05211f9d2267 to 87c1667dfd1e (1 revision) (flutter/flutter#155681)
2024-09-25 [email protected] Roll Flutter Engine from 8d1eb7410b49 to 05211f9d2267 (1 revision) (flutter/flutter#155672)
2024-09-25 [email protected] Roll Flutter Engine from ad3dd0df0fe7 to 8d1eb7410b49 (2 revisions) (flutter/flutter#155662)
2024-09-25 [email protected] Roll Flutter Engine from 746ce6124844 to ad3dd0df0fe7 (2 revisions) (flutter/flutter#155653)
2024-09-25 [email protected] Add PrivacyInfo.xcprivacy to macOS plugin template (flutter/flutter#155570)
2024-09-25 [email protected] Roll Flutter Engine from 559f2ff31c74 to 746ce6124844 (14 revisions) (flutter/flutter#155648)
2024-09-25 [email protected] fix `SearchAnchor` disposing `SearchController` while it is still used (flutter/flutter#155219)
2024-09-25 [email protected] Roll pub packages (flutter/flutter#155640)
2024-09-24 [email protected] Preserve transform when using *Gradient:withOpacity (flutter/flutter#154908)
2024-09-24 [email protected] fixed keyboardDismissBehavior on scroll without a drag (flutter/flutter#154675)
2024-09-24 [email protected] Roll Flutter Engine from 7cd3d0b1bb2e to 559f2ff31c74 (3 revisions) (flutter/flutter#155629)
2024-09-24 [email protected] Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (flutter/flutter#155625)
2024-09-24 [email protected] Misc docs cleanup and fixes (flutter/flutter#155501)
2024-09-24 [email protected] Roll Flutter Engine from dc44f95b7027 to 2a13c3a27e1f (1 revision) (flutter/flutter#155619)
2024-09-24 [email protected] Roll Flutter Engine from 2745b8797025 to dc44f95b7027 (1 revision) (flutter/flutter#155616)
2024-09-24 [email protected] Roll Flutter Engine from 8a54cc56d4b9 to 2745b8797025 (2 revisions) (flutter/flutter#155610)
2024-09-24 [email protected] Roll Flutter Engine from c07812775255 to 8a54cc56d4b9 (2 revisions) (flutter/flutter#155607)
2024-09-24 [email protected] Roll Packages from 9de72be to 4926c0f (4 revisions) (flutter/flutter#155605)
2024-09-24 [email protected] Fix some broken links in DAP readme (flutter/flutter#155600)
2024-09-24 [email protected] Roll Flutter Engine from 22e4f015cc99 to c07812775255 (2 revisions) (flutter/flutter#155599)
2024-09-24 [email protected] [flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (flutter/flutter#155249)
2024-09-24 [email protected] Roll Flutter Engine from 309468cfd1bb to 22e4f015cc99 (2 revisions) (flutter/flutter#155591)
2024-09-24 [email protected] [native assets] Roll dependencies (flutter/flutter#155432)
2024-09-24 [email protected] Roll Flutter Engine from 4013dc28a48b to 309468cfd1bb (2 revisions) (flutter/flutter#155588)
2024-09-24 [email protected] Roll Flutter Engine from 8a5af19a43f3 to 4013dc28a48b (1 revision) (flutter/flutter#155585)
2024-09-24 [email protected] Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) (flutter/flutter#155583)
2024-09-24 [email protected] Add `WidgetStateProperty` example and tests for it. (flutter/flutter#155315)
2024-09-24 [email protected] Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (flutter/flutter#155579)
2024-09-23 [email protected] Roll Flutter Engine from 61f0a3fbabbe to 9bb0ece79ae2 (2 revisions) (flutter/flutter#155549)
2024-09-23 [email protected] Assert macOS framework artifact contains xcprivacy manifest (flutter/flutter#155189)
2024-09-23 [email protected] Roll Packages from f54fe93 to 9de72be (1 revision) (flutter/flutter#155540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from 4ca51a1 to 538e742 (40 revisions) (flutter#7705)
39a78e6 
Roll Flutter from 4ca51a1 to 538e742 (40 revisions)

flutter/flutter@4ca51a1...538e742

2024-09-25 [email protected] Marks Linux build_aar_module_test to be unflaky (flutter/flutter#155349)
2024-09-25 [email protected] Roll Packages from 96880cb to 7ee5ae7 (3 revisions) (flutter/flutter#155701)
2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Normalize TabBarTheme (#155476)" (flutter/flutter#155698)
2024-09-25 [email protected] Normalize TabBarTheme (flutter/flutter#155476)
2024-09-25 [email protected] increase both linux & windows tool integration test shards (flutter/flutter#155631)
2024-09-25 [email protected] Roll Flutter Engine from c7cd559e483b to d6d5fdba6ae1 (1 revision) (flutter/flutter#155693)
2024-09-25 [email protected] Add WidgetStateBorderSide example and tests for it. (flutter/flutter#155559)
2024-09-25 [email protected] Roll Flutter Engine from b9dd7a39dd58 to c7cd559e483b (1 revision) (flutter/flutter#155686)
2024-09-25 [email protected] Roll Flutter Engine from 87c1667dfd1e to b9dd7a39dd58 (1 revision) (flutter/flutter#155684)
2024-09-25 [email protected] Roll Flutter Engine from 05211f9d2267 to 87c1667dfd1e (1 revision) (flutter/flutter#155681)
2024-09-25 [email protected] Roll Flutter Engine from 8d1eb7410b49 to 05211f9d2267 (1 revision) (flutter/flutter#155672)
2024-09-25 [email protected] Roll Flutter Engine from ad3dd0df0fe7 to 8d1eb7410b49 (2 revisions) (flutter/flutter#155662)
2024-09-25 [email protected] Roll Flutter Engine from 746ce6124844 to ad3dd0df0fe7 (2 revisions) (flutter/flutter#155653)
2024-09-25 [email protected] Add PrivacyInfo.xcprivacy to macOS plugin template (flutter/flutter#155570)
2024-09-25 [email protected] Roll Flutter Engine from 559f2ff31c74 to 746ce6124844 (14 revisions) (flutter/flutter#155648)
2024-09-25 [email protected] fix `SearchAnchor` disposing `SearchController` while it is still used (flutter/flutter#155219)
2024-09-25 [email protected] Roll pub packages (flutter/flutter#155640)
2024-09-24 [email protected] Preserve transform when using *Gradient:withOpacity (flutter/flutter#154908)
2024-09-24 [email protected] fixed keyboardDismissBehavior on scroll without a drag (flutter/flutter#154675)
2024-09-24 [email protected] Roll Flutter Engine from 7cd3d0b1bb2e to 559f2ff31c74 (3 revisions) (flutter/flutter#155629)
2024-09-24 [email protected] Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (flutter/flutter#155625)
2024-09-24 [email protected] Misc docs cleanup and fixes (flutter/flutter#155501)
2024-09-24 [email protected] Roll Flutter Engine from dc44f95b7027 to 2a13c3a27e1f (1 revision) (flutter/flutter#155619)
2024-09-24 [email protected] Roll Flutter Engine from 2745b8797025 to dc44f95b7027 (1 revision) (flutter/flutter#155616)
2024-09-24 [email protected] Roll Flutter Engine from 8a54cc56d4b9 to 2745b8797025 (2 revisions) (flutter/flutter#155610)
2024-09-24 [email protected] Roll Flutter Engine from c07812775255 to 8a54cc56d4b9 (2 revisions) (flutter/flutter#155607)
2024-09-24 [email protected] Roll Packages from d6a4abf to 96880cb (4 revisions) (flutter/flutter#155605)
2024-09-24 [email protected] Fix some broken links in DAP readme (flutter/flutter#155600)
2024-09-24 [email protected] Roll Flutter Engine from 22e4f015cc99 to c07812775255 (2 revisions) (flutter/flutter#155599)
2024-09-24 [email protected] [flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (flutter/flutter#155249)
2024-09-24 [email protected] Roll Flutter Engine from 309468cfd1bb to 22e4f015cc99 (2 revisions) (flutter/flutter#155591)
2024-09-24 [email protected] [native assets] Roll dependencies (flutter/flutter#155432)
2024-09-24 [email protected] Roll Flutter Engine from 4013dc28a48b to 309468cfd1bb (2 revisions) (flutter/flutter#155588)
2024-09-24 [email protected] Roll Flutter Engine from 8a5af19a43f3 to 4013dc28a48b (1 revision) (flutter/flutter#155585)
2024-09-24 [email protected] Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) (flutter/flutter#155583)
2024-09-24 [email protected] Add `WidgetStateProperty` example and tests for it. (flutter/flutter#155315)
2024-09-24 [email protected] Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (flutter/flutter#155579)
2024-09-23 [email protected] Roll Flutter Engine from 61f0a3fbabbe to 9bb0ece79ae2 (2 revisions) (flutter/flutter#155549)
2024-09-23 [email protected] Assert macOS framework artifact contains xcprivacy manifest (flutter/flutter#155189)
2024-09-23 [email protected] Roll Packages from b94e6f8 to d6a4abf (1 revision) (flutter/flutter#155540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@victorsanni victorsanni victorsanni approved these changes
@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autocomplete field options in the SingleChildScrollView remains open even when field goes out of view.

5 participants

@nick9822 @goderbauer @priyankabambharoliya-official @Piinks @victorsanni