Skip to content

Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. (#154048)" - #154743

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert_0eaeb0d1c5dc8b6d705828e7eebe0fc16b47419b
Sep 6, 2024
Merged

Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. (#154048)"#154743
auto-submit[bot] merged 1 commit into
masterfrom
revert_0eaeb0d1c5dc8b6d705828e7eebe0fc16b47419b

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Reverts: #154048

Initiated by: nate-thegrate

Reason for reverting: using AnimationStyle instead would allow for complete animation duration and curve customization.

Original PR Author: nploi

Reviewed By: {piedcipher, nate-thegrate}

This change reverts the following previous change:
Currently we don't support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods , This PR will to support that.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

auto-submit[bot]
Revert "Support custom transition duration for DialogRoute, `Cupert…
1afed1d 
…inoDialogRoute` and show dialog methods. (#154048)"

This reverts commit 0eaeb0d.
@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Sep 6, 2024
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages f: routes Navigator, Router, and related APIs. labels Sep 6, 2024
@auto-submit
auto-submit Bot merged commit 8c6513d into master Sep 6, 2024
@auto-submit
auto-submit Bot deleted the revert_0eaeb0d1c5dc8b6d705828e7eebe0fc16b47419b branch September 6, 2024 19:13
@nate-thegrate
nate-thegrate removed the request for review from TahaTesser September 6, 2024 19:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
e1c0f52 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
aa969df 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
c63680e 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
4b6e027 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
aacb19d 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
31fc768 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
07a6be1 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
2e75ee1 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
8878646 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
302d84a 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
8bee805 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
7c2ed6e 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
815143f 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
cc6f338 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
ef5f726 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
f58b92b 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
6768851 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
33dd910 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
99f6761 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
e441344 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
2098b8d 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
84da375 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
70a5cef 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
4e88494 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
33bcd93 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
c2fb906 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
8c6513d Reverts "Support custom transition duration for DialogRoute…
6fa568f 
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@nate-thegrate nate-thegrate

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluttergithubbot @nate-thegrate