Skip to content

CheckboxListTile: add property to scale the checkbox - #154806

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
itsjatinnagar:master
Oct 6, 2024
Merged

auto-submit[bot] merged 7 commits into
flutter:masterfrom
itsjatinnagar:master

Conversation

@itsjatinnagar

@itsjatinnagar itsjatinnagar commented Sep 9, 2024 •

Copy link
Copy Markdown
Contributor

Added a property in the CheckboxListTile to scale the underlying Checkbox using Transform.scale.

Fixes: #81334

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Sep 9, 2024
@MitchellGoodwin

Copy link
Copy Markdown
Contributor

Copying comment from the Discord on the test:

"There's a test file for the CheckBoxListTile in packages/flutter/test/material. I imagine you can just find the checkbox widget and get it's corners then compare them against an expected value, but if that doesn't work, you can look up the tests for Transform.scale and see if there's a helpful one there to get you started."

@itsjatinnagar

Copy link
Copy Markdown
Contributor Author

Hi @MitchellGoodwin
I've added the tests. Please go through them in 1af3872

Thanks

@MitchellGoodwin MitchellGoodwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit! Thank you very much for putting this together. Once then nit is addressed I'll see about getting a secondary reviewer, than this can be merged.

Comment thread packages/flutter/lib/src/material/checkbox_list_tile.dart Outdated
Comment thread packages/flutter/lib/src/material/checkbox_list_tile.dart Outdated
@victorsanni

Copy link
Copy Markdown
Contributor

@itsjatinnagar the linked issue also mentions scaling the underlying Radio in a RadioListTile. Is this planned in a subsequent PR?

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but +1 to @victorsanni's comment about the docs.

@itsjatinnagar

Copy link
Copy Markdown
Contributor Author

@itsjatinnagar the linked issue also mentions scaling the underlying Radio in a RadioListTile. Is this planned in a subsequent PR?

Yes, I am going to raise a new PR for Radio.

Comment thread packages/flutter/lib/src/material/checkbox_list_tile.dart Outdated
Comment thread packages/flutter/lib/src/material/checkbox_list_tile.dart Outdated
Comment thread packages/flutter/lib/src/material/checkbox_list_tile.dart Outdated
Comment thread packages/flutter/test/material/checkbox_list_tile_test.dart Outdated
Comment thread packages/flutter/test/material/checkbox_list_tile_test.dart Outdated
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2024
@auto-submit
auto-submit Bot merged commit bae7971 into flutter:master Oct 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox/Radio size

4 participants