Repository navigation
Fail ios workflow when simctl does not work - #15628
Merged
Merged
Conversation
yjbanov
approved these changes
Mar 16, 2018
Contributor
|
|
cbracken
reviewed
Mar 16, 2018
| if (!xcode.isSimctlInstalled) { | ||
| xcodeStatus = ValidationType.partial; | ||
| messages.add(new ValidationMessage.error( | ||
| 'Xcode requires additional components to be installed in order to run. Launch Xcode and install ' |
Member
There was a problem hiding this comment.
nit: I'd add a linebreak after the period.
cbracken
reviewed
Mar 16, 2018
| _isSimctlInstalled = false; | ||
| } else { | ||
| _isSimctlInstalled = true; | ||
| } |
Member
There was a problem hiding this comment.
shorter: _isSimctlInstalled = result.stderr == null;
cbracken
approved these changes
Mar 16, 2018
Member
|
lgtm modulo comments. |
Contributor
|
This has been identified as the culprit of #15697 - @jonahwilliams sounds like you're rolling this back? |
Contributor
Author
|
Rollback failed, I have a forward fix ready to go |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* fail ios workflow when simctl does not work * missed rename commit * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13063 by
xcrun simctl listdoes not exit successfully. This prints a message that the user must open xcode and install required components.simctlis not enabled