Repository navigation
Arrow syntax for getters - #156483
Merged
Merged
Arrow syntax for getters#156483
Conversation
github-actions
Bot
added
a: tests
andrewkolos
reviewed
Oct 10, 2024
Piinks
reviewed
Oct 15, 2024
| return false; | ||
| } | ||
| } | ||
| bool get _isOnDesktopAndWeb => kIsWeb || switch (defaultTargetPlatform) { |
Contributor
There was a problem hiding this comment.
This looks incorrect based on the name.. should this be true only iff it is desktop && web?
Contributor
There was a problem hiding this comment.
To be clear, I am wondering if the original logic was incorrect to begin with.
Contributor
Author
There was a problem hiding this comment.
Absolutely: either the logic should be changed to use && or the getter should be renamed to _isOnDesktopOrWeb.
I could change it now, though perhaps that's outside the scope of this PR.
Contributor
There was a problem hiding this comment.
Yeah definitely something to follow up on separately.
github-actions
Bot
removed
a: tests
Contributor
|
Rebasing should fix the failing check. |
nate-thegrate
force-pushed
the
arrow-syntax
branch
from
October 17, 2024 16:49
7744e74 to
d16ee4a
Compare
nate-thegrate
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
This comment was marked as resolved.
This comment was marked as resolved.
nate-thegrate
added
the
autosubmit
Contributor
|
Yes, please! More of this! |
nate-thegrate
added
the
refactor
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This egotistical PR aims to draw attention to a style guideline that I changed:
There was an opportunity for valuable discussion in #154753 about how this structure affects readability, but I shut it down pretty quick since there was a lot of other stuff going on there.
Interested to hear thoughts from @Piinks and others.