Repository navigation
Make android dependency version test suite run on changes to templates - #157196
Merged
auto-submit[bot] merged 5 commits intoOct 21, 2024
Merged
Conversation
9 tasks done
bartekpacia
approved these changes
Oct 18, 2024
bartekpacia
left a comment
bartekpacia
left a comment
Member
There was a problem hiding this comment.
LGTM, assuming all tests pass
gmackall
commented
Oct 18, 2024
| test_timeout_secs: "2700" | ||
| runIf: | ||
| - packages/flutter_tools/templates/** | ||
| - .ci.yaml |
Member
Author
There was a problem hiding this comment.
.ci.yamlseems required, otherwise format checks failpackages/flutter_tools/templates/**could probably be a little more specific, but the path specification would get a lot more complicated, because the android templates are spread out across a number of directories w/ different names,
i.e, withinpackages/flutter_tools/templates/app_shared, we'd need to specify each of:
...
android-java.tmpl
android-kotlin.tmpl
android.tmpl
...
and then we would have to do this for each template. But as is these tests will get triggered for non-android changes to templates which doesn't seem like a huge deal to me.
Open to opinions
gmackall
marked this pull request as ready for review
October 18, 2024 22:12
9 tasks done
gmackall
changed the title
reidbaker
approved these changes
Oct 21, 2024
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a group of tests that verifies that we can build a flutter app across the range of AGP, Kotlin, and Gradle versions we claim to support. They currently only run on postsubmit.
This pr aims to make them run in presubmit as well, but only when changes are made to the templates (not just android templates, see #157196 (comment) as to why).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.