Skip to content

Remove the only reference to settings.gradle.legacy_versions. - #157380

Merged
matanlurey merged 1 commit into
flutter:masterfrom
matanlurey:remove-legacy-versions
Oct 22, 2024
Merged

Remove the only reference to settings.gradle.legacy_versions.#157380
matanlurey merged 1 commit into
flutter:masterfrom
matanlurey:remove-legacy-versions

Conversation

@matanlurey

@matanlurey matanlurey commented Oct 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 22, 2024
jonahwilliams
jonahwilliams approved these changes Oct 22, 2024
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@auto-submit

auto-submit Bot commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/157380, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey
matanlurey merged commit 5a1ae97 into flutter:master Oct 22, 2024
@matanlurey
matanlurey deleted the remove-legacy-versions branch October 22, 2024 21:04
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
@matanlurey @M97Chahboun
Remove the only reference to settings.gradle.legacy_versions. (flut…
bd181ff 
…ter#157380)

Code references:
https://github.com/search?q=repo%3Aflutter%2Fflutter%20%22legacy_versions%22&type=code.

Closes flutter#87922.

Work towards flutter#48918.
@andrewkolos andrewkolos mentioned this pull request Nov 11, 2024
Merged
8 of 9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
5a1ae97 Remove the only reference to `settings.gradle.legacy_versions…
edf5d2b 
…`. (flutter/flutter#157380)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
5a1ae97 Remove the only reference to `settings.gradle.legacy_versions…
97a0c70 
…`. (flutter/flutter#157380)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
5a1ae97 Remove the only reference to `settings.gradle.legacy_versions…
4a08cc3 
…`. (flutter/flutter#157380)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
5a1ae97 Remove the only reference to `settings.gradle.legacy_versions…
b64dc72 
…`. (flutter/flutter#157380)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
5a1ae97 Remove the only reference to `settings.gradle.legacy_versions…
f42ae86 
…`. (flutter/flutter#157380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gradle_test.dart: move integration test to the integration shard.

2 participants

@matanlurey @jonahwilliams