Add test for `focus_node.unfocus.0.dart` by ValentinVignal · Pull Request #157673 · flutter/flutter

ValentinVignal · 2024-10-26T14:49:40Z

Contributes to #130459

It adds a test for

examples/api/lib/widgets/focus_manager/focus_node.unfocus.0.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux · 2024-10-28T06:17:19Z

+      await tester.tap(find.byType(TextField).first); // Focuses the first text field.
+      await tester.pump();


Suggested change

await tester.tap(find.byType(TextField).first); // Focuses the first text field.

await tester.pump();

// Focuses the first text field.

await tester.tap(find.byType(TextField).first);

await tester.pump();

Cosmetic change to use the same commenting approach than below.

bleroux

LGTM! with minor comments

bleroux · 2024-10-28T06:17:32Z

+      expect(
+        find.descendant(
+          of: find.byType(TextField).first,
+          matching: find.byWidgetPredicate(
+            (Widget focus) => focus is Focus && (focus.focusNode?.hasFocus ?? false),
+          ),
+        ),
+        findsOne,
+      );


Not sure it is better, but if you want something shorter, the following is probably ok:

final EditableText firstEditableText = tester.firstWidget(find.byType(EditableText)); expect(firstEditableText.focusNode.hasFocus, true);

Sure ! I changed it in test: Shorter expects

bleroux · 2024-10-28T06:17:46Z

+      await tester.tap(find.byType(TextField).first); // Focuses the first text field.
+      await tester.pump();


Suggested change

await tester.tap(find.byType(TextField).first); // Focuses the first text field.

await tester.pump();

// Focuses the first text field.

await tester.tap(find.byType(TextField).first);

await tester.pump();

)

flutter/flutter@5a11904...3fb95c7 2024-10-28 [email protected] Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) (flutter/flutter#157736) 2024-10-28 [email protected] Avoid labeling 'context' PRs as 'text-input' (flutter/flutter#157650) 2024-10-28 [email protected] Add test for `restorable_route_future.0.dart` (flutter/flutter#157708) 2024-10-28 [email protected] Update .ci.yaml have android sdk be 35v1 (flutter/flutter#157621) 2024-10-28 [email protected] Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) (flutter/flutter#157713) 2024-10-28 [email protected] Add test for `restoration_mixin.0.dart` (flutter/flutter#157709) 2024-10-28 [email protected] Add test for `navigator.restorable_push_replacement.0.dart` (flutter/flutter#157704) 2024-10-28 [email protected] Add test for `focus_node.unfocus.0.dart` (flutter/flutter#157673) 2024-10-28 [email protected] Roll Flutter Engine from 9226b089d634 to 2522789c4199 (2 revisions) (flutter/flutter#157710) 2024-10-28 [email protected] Add tests for `navigator_state.restorable_push.0.dart` (flutter/flutter#157667) 2024-10-28 [email protected] Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) (flutter/flutter#157702) 2024-10-28 [email protected] Add test for `navigator_state.restorable_push_replacement.0.dart` (flutter/flutter#157668) 2024-10-28 [email protected] Remove unsafe_html lint rule (flutter/flutter#157531) 2024-10-27 [email protected] Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) (flutter/flutter#157690) 2024-10-27 [email protected] Fix Scaffold extend body (flutter/flutter#157441) 2024-10-26 [email protected] Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) (flutter/flutter#157681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

)

flutter/flutter@5a11904...3fb95c7 2024-10-28 [email protected] Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) (flutter/flutter#157736) 2024-10-28 [email protected] Avoid labeling 'context' PRs as 'text-input' (flutter/flutter#157650) 2024-10-28 [email protected] Add test for `restorable_route_future.0.dart` (flutter/flutter#157708) 2024-10-28 [email protected] Update .ci.yaml have android sdk be 35v1 (flutter/flutter#157621) 2024-10-28 [email protected] Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) (flutter/flutter#157713) 2024-10-28 [email protected] Add test for `restoration_mixin.0.dart` (flutter/flutter#157709) 2024-10-28 [email protected] Add test for `navigator.restorable_push_replacement.0.dart` (flutter/flutter#157704) 2024-10-28 [email protected] Add test for `focus_node.unfocus.0.dart` (flutter/flutter#157673) 2024-10-28 [email protected] Roll Flutter Engine from 9226b089d634 to 2522789c4199 (2 revisions) (flutter/flutter#157710) 2024-10-28 [email protected] Add tests for `navigator_state.restorable_push.0.dart` (flutter/flutter#157667) 2024-10-28 [email protected] Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) (flutter/flutter#157702) 2024-10-28 [email protected] Add test for `navigator_state.restorable_push_replacement.0.dart` (flutter/flutter#157668) 2024-10-28 [email protected] Remove unsafe_html lint rule (flutter/flutter#157531) 2024-10-27 [email protected] Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) (flutter/flutter#157690) 2024-10-27 [email protected] Fix Scaffold extend body (flutter/flutter#157441) 2024-10-26 [email protected] Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) (flutter/flutter#157681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels Oct 26, 2024

bleroux reviewed Oct 28, 2024

View reviewed changes

bleroux approved these changes Oct 28, 2024

View reviewed changes

ValentinVignal added 2 commits October 28, 2024 16:34

test: Add test for focus_node.unfocus.0.dart

47bda12

test: Shorter expects

cdee05f

ValentinVignal force-pushed the flutter/api/example/Add-test-for-focus-node-unfocus branch from a3fa482 to cdee05f Compare October 28, 2024 08:34

ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2024

auto-submit Bot merged commit d9cb4b8 into flutter:master Oct 28, 2024

engine-flutter-autoroll mentioned this pull request Oct 28, 2024

Roll Flutter from 5a11904383d1 to a1587bdf2fec (12 revisions) flutter/packages#7942

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2024

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

6bff458

)

engine-flutter-autoroll mentioned this pull request Oct 28, 2024

Roll Flutter from 5a11904383d1 to bac39a3899e4 (13 revisions) flutter/packages#7945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2024

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

8914edc

)

engine-flutter-autoroll mentioned this pull request Oct 28, 2024

Roll Flutter from 5a11904383d1 to ab256e5caff0 (14 revisions) flutter/packages#7946

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2024

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

fdc75ea

)

engine-flutter-autoroll mentioned this pull request Oct 28, 2024

Roll Flutter from 5a11904383d1 to 4a4664946bcf (15 revisions) flutter/packages#7947

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2024

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

e53da19

)

engine-flutter-autoroll mentioned this pull request Oct 28, 2024

Roll Flutter from 5a11904383d1 to 3fb95c7dd21d (16 revisions) flutter/packages#7948

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2024

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

bcefb02

)

Piinks mentioned this pull request Nov 8, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

c2cf1bd

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

63a5b51

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

9f7a94b

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

8fcb991

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

d9cb4b8 Add test for focus_node.unfocus.0.dart (flutter/flutter#157673

8369f27

)

Navigation Menu

Repository navigation

Add test for `focus_node.unfocus.0.dart` - #157673

Add test for `focus_node.unfocus.0.dart`#157673
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-focus-node-unfocus

ValentinVignal commented Oct 26, 2024

Uh oh!

bleroux Oct 28, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Oct 28, 2024

Uh oh!

ValentinVignal Oct 28, 2024

Uh oh!

bleroux Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		await tester.tap(find.byType(TextField).first); // Focuses the first text field.
		await tester.pump();

Conversation

ValentinVignal commented Oct 26, 2024

Pre-launch Checklist

Uh oh!

bleroux Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants