Refactor DropdownMenu tests by bleroux · Pull Request #157913 · flutter/flutter

bleroux · 2024-10-31T08:42:57Z

Description

This PR introduces some utility functions to simplify some DropdownMenu tests.
The main purpose is to centralize and document how tests should find menu items, because it is tricky as there are two occurrences of each widgets and using '.last' is mandatory:

  Finder findMenuItemButton(String label) {
    // For each menu items there are two MenuItemButton widgets.
    // The last one is the real button item in the menu.
    // The first one is not visible, it is part of _DropdownMenuBody
    // which is used to compute the dropdown width.
    return find.widgetWithText(MenuItemButton, label).last;
  }

Related Issue

This is extracted from #157496.

Tests

Refactors many existing tests.

bleroux · 2024-10-31T09:11:37Z

@QuncCccccc I extracted this PR from #157496 because I think those refactorings are valuable whether we move forward or not on #157496.

justinmc

LGTM 👍 Thanks for cleaning this up.

justinmc · 2024-11-05T00:38:32Z

 import 'package:flutter_test/flutter_test.dart';

 void main() {
+  Finder findMenuItemButton(String label) {


Sometimes I'll create a utils file to share methods like these that are used in multiple test files (e.g. editable_text_utils.dart). Probably not worth it in this case but up to you.

Great reminder 🙏
I have 3 DropdownMenu/MenuAnchor PRs on the work, I will try to figure out if such a utils file is possible.

flutter/flutter@8591d0c...29d40f7 2024-11-05 [email protected] increase subsharding for `Windows build_tests` from 8 to 9 (flutter/flutter#158146) 2024-11-05 [email protected] Reland2: Revert "Revert "Add a warning/additional handlers for parsing`synthetic-package`."" (flutter/flutter#158184) 2024-11-05 [email protected] Reland1: "Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`."" (flutter/flutter#158126) 2024-11-05 [email protected] Roll Packages from 796afa3 to 7219431 (11 revisions) (flutter/flutter#158179) 2024-11-05 [email protected] Make native asset integration test more robust, thereby allowing smooth auto-update of packages via `flutter update-packages` (flutter/flutter#158170) 2024-11-05 [email protected] Readability change to `flutter.groovy`, align on null assignment, reduce unused scope for some methods, apply static where possible (flutter/flutter#157471) 2024-11-05 [email protected] Roll Flutter Engine from 7207a8fbec93 to f56401062e42 (1 revision) (flutter/flutter#158169) 2024-11-05 [email protected] Add test for `raw_scrollbar.shape.0.dart` (flutter/flutter#158094) 2024-11-05 [email protected] Roll Flutter Engine from 418609dd5b58 to 7207a8fbec93 (1 revision) (flutter/flutter#158156) 2024-11-05 [email protected] Refactor DropdownMenu tests (flutter/flutter#157913) 2024-11-05 [email protected] Roll Flutter Engine from 6271a92a376f to 418609dd5b58 (3 revisions) (flutter/flutter#158152) 2024-11-05 [email protected] Marks Linux_pixel_7pro flavors_test to be flaky (flutter/flutter#156956) 2024-11-05 [email protected] Further remove web-only considerations that are no longer necessary (flutter/flutter#158143) 2024-11-05 [email protected] Add optional parameter to FlutterTesterDevices. (flutter/flutter#158133) 2024-11-05 [email protected] Roll Flutter Engine from 75acceedca41 to 6271a92a376f (2 revisions) (flutter/flutter#158148) 2024-11-05 [email protected] Extract and restore a test that a blank native assets project still builds (flutter/flutter#158141) 2024-11-04 [email protected] Remove references to the HTML renderer in public docs. (flutter/flutter#158035) 2024-11-04 [email protected] Roll Flutter Engine from f880b56b6ede to 75acceedca41 (1 revision) (flutter/flutter#158137) 2024-11-04 [email protected] Fix `WidgetStateProperty` documentation (flutter/flutter#154298) 2024-11-04 [email protected] Roll Flutter Engine from 25c7e471e2ef to f880b56b6ede (5 revisions) (flutter/flutter#158132) 2024-11-04 [email protected] Roll Flutter Engine from 05cb5d7f7939 to 25c7e471e2ef (12 revisions) (flutter/flutter#158127) 2024-11-04 [email protected] Remove use_modular_headers! from Swift Podfiles (flutter/flutter#156257) 2024-11-04 [email protected] Disable failing native assets test (flutter/flutter#158119) 2024-11-04 [email protected] Fix `NestedScrollView` inner position logic (flutter/flutter#157756) 2024-11-04 [email protected] Add benchmarks for single-threaded Skwasm. (flutter/flutter#158027) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@8591d0c...29d40f7 2024-11-05 [email protected] increase subsharding for `Windows build_tests` from 8 to 9 (flutter/flutter#158146) 2024-11-05 [email protected] Reland2: Revert "Revert "Add a warning/additional handlers for parsing`synthetic-package`."" (flutter/flutter#158184) 2024-11-05 [email protected] Reland1: "Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`."" (flutter/flutter#158126) 2024-11-05 [email protected] Roll Packages from fbbb277 to 63023d9 (11 revisions) (flutter/flutter#158179) 2024-11-05 [email protected] Make native asset integration test more robust, thereby allowing smooth auto-update of packages via `flutter update-packages` (flutter/flutter#158170) 2024-11-05 [email protected] Readability change to `flutter.groovy`, align on null assignment, reduce unused scope for some methods, apply static where possible (flutter/flutter#157471) 2024-11-05 [email protected] Roll Flutter Engine from 7207a8fbec93 to f56401062e42 (1 revision) (flutter/flutter#158169) 2024-11-05 [email protected] Add test for `raw_scrollbar.shape.0.dart` (flutter/flutter#158094) 2024-11-05 [email protected] Roll Flutter Engine from 418609dd5b58 to 7207a8fbec93 (1 revision) (flutter/flutter#158156) 2024-11-05 [email protected] Refactor DropdownMenu tests (flutter/flutter#157913) 2024-11-05 [email protected] Roll Flutter Engine from 6271a92a376f to 418609dd5b58 (3 revisions) (flutter/flutter#158152) 2024-11-05 [email protected] Marks Linux_pixel_7pro flavors_test to be flaky (flutter/flutter#156956) 2024-11-05 [email protected] Further remove web-only considerations that are no longer necessary (flutter/flutter#158143) 2024-11-05 [email protected] Add optional parameter to FlutterTesterDevices. (flutter/flutter#158133) 2024-11-05 [email protected] Roll Flutter Engine from 75acceedca41 to 6271a92a376f (2 revisions) (flutter/flutter#158148) 2024-11-05 [email protected] Extract and restore a test that a blank native assets project still builds (flutter/flutter#158141) 2024-11-04 [email protected] Remove references to the HTML renderer in public docs. (flutter/flutter#158035) 2024-11-04 [email protected] Roll Flutter Engine from f880b56b6ede to 75acceedca41 (1 revision) (flutter/flutter#158137) 2024-11-04 [email protected] Fix `WidgetStateProperty` documentation (flutter/flutter#154298) 2024-11-04 [email protected] Roll Flutter Engine from 25c7e471e2ef to f880b56b6ede (5 revisions) (flutter/flutter#158132) 2024-11-04 [email protected] Roll Flutter Engine from 05cb5d7f7939 to 25c7e471e2ef (12 revisions) (flutter/flutter#158127) 2024-11-04 [email protected] Remove use_modular_headers! from Swift Podfiles (flutter/flutter#156257) 2024-11-04 [email protected] Disable failing native assets test (flutter/flutter#158119) 2024-11-04 [email protected] Fix `NestedScrollView` inner position logic (flutter/flutter#157756) 2024-11-04 [email protected] Add benchmarks for single-threaded Skwasm. (flutter/flutter#158027) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Refactor DropdownMenu tests

03ae905

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Oct 31, 2024

bleroux requested a review from QuncCccccc October 31, 2024 09:09

nate-thegrate added the refactor Improving readability/efficiency without behavioral changes label Nov 1, 2024

bleroux requested a review from justinmc November 4, 2024 18:43

justinmc approved these changes Nov 5, 2024

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2024

auto-submit Bot merged commit 338555b into flutter:master Nov 5, 2024

bleroux deleted the refactor_DropdownMenu_tests branch November 5, 2024 06:17

engine-flutter-autoroll mentioned this pull request Nov 5, 2024

Roll Flutter from 8591d0c16a6c to ecc24371860c (20 revisions) flutter/packages#8022

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2024

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

88f52b2

engine-flutter-autoroll mentioned this pull request Nov 5, 2024

Roll Flutter from 8591d0c16a6c to 31c1292be3fa (21 revisions) flutter/packages#8023

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2024

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

0ce921c

engine-flutter-autoroll mentioned this pull request Nov 5, 2024

Roll Flutter from 8591d0c16a6c to 04d3d1a4c3f0 (23 revisions) flutter/packages#8024

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2024

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

60cdcc7

engine-flutter-autoroll mentioned this pull request Nov 5, 2024

Roll Flutter from 8591d0c16a6c to b8519bc21ed0 (24 revisions) flutter/packages#8026

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2024

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

c1a34c7

engine-flutter-autoroll mentioned this pull request Nov 5, 2024

Roll Flutter from 8591d0c16a6c to 29d40f7f6826 (25 revisions) flutter/packages#8027

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2024

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

0363c41

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

9fbf6dc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

8981df2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

ba72638

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

8072b9f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

338555b Refactor DropdownMenu tests (flutter/flutter#157913)

63fabbc

Navigation Menu

Repository navigation

Refactor DropdownMenu tests - #157913

Refactor DropdownMenu tests#157913
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:refactor_DropdownMenu_tests

bleroux commented Oct 31, 2024 •

edited

Loading

Uh oh!

bleroux commented Oct 31, 2024

Uh oh!

justinmc left a comment

Uh oh!

justinmc Nov 5, 2024

Uh oh!

bleroux Nov 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bleroux commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Tests

Uh oh!

bleroux commented Oct 31, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bleroux commented Oct 31, 2024 •

edited

Loading