Add test for `raw_scrollbar.2.dart` by ValentinVignal · Pull Request #158161 · flutter/flutter

ValentinVignal · 2024-11-05T09:43:24Z

Contributes to #130459

It adds a test for

examples/api/lib/widgets/scrollbar/raw_scrollbar.2.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

LGTM! 🙏
See my comment about improving the existing examples.

bleroux · 2024-11-05T10:15:33Z


+  @override
+  void dispose() {
+    _firstController.dispose();


Good catch for those missing dispose 🎉

Consider renaming the _firstController variable to _controller or _scrollController and do the same for the other scrollbar examples.

raw_scrollbar.0.dart is also wrongly formatted, consider fixing it, as you want.

flutter/flutter@29d40f7...73546b3 2024-11-06 [email protected] Add test for `image.loading_builder.0.dart` (flutter/flutter#158248) 2024-11-06 [email protected] Make flutter_tools use newest package:{native_assets_builder,native_assets_cli,native_toolchain_c} (flutter/flutter#158214) 2024-11-06 [email protected] Fix RawScrollbar examples and desktop test (flutter/flutter#158237) 2024-11-06 [email protected] Cleanup MenuAnchor and Improve DropdownMenu tests readability (flutter/flutter#158175) 2024-11-06 [email protected] Roll Flutter Engine from a3741d6248b7 to f03f11300a9d (2 revisions) (flutter/flutter#158222) 2024-11-06 [email protected] Update error message for Cocoapods support for synchronized groups/folders (flutter/flutter#158206) 2024-11-06 [email protected] Restore skipped iOS test by looping over `FakeAsync` elapse. (flutter/flutter#158204) 2024-11-06 [email protected] fix: ensure draggable_scrollable_sheet respects shouldCloseOnMinExtenâ�¦ (flutter/flutter#156338) 2024-11-06 [email protected] Roll Flutter Engine from e5e06c97c33c to a3741d6248b7 (14 revisions) (flutter/flutter#158218) 2024-11-06 [email protected] Forward fix `CupertinoDynamicColor` by adding `toARGB32()`. (flutter/flutter#158145) 2024-11-05 [email protected] Remove unused `enableObservatory` flag. (flutter/flutter#158202) 2024-11-05 [email protected] Remove observatory related TODO that is already fixed. (flutter/flutter#158205) 2024-11-05 [email protected] Factor out "shaker" class (flutter/flutter#157748) 2024-11-05 [email protected] Marks Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary to be flaky (flutter/flutter#157424) 2024-11-05 [email protected] Increase subsharding for `Linux tool_integration_tests` (flutter/flutter#158196) 2024-11-05 [email protected] Add test for `raw_scrollbar.2.dart` (flutter/flutter#158161) 2024-11-05 [email protected] use root directory as the default for rootOverride in Cache.test constructor (flutter/flutter#158201) 2024-11-05 [email protected] Kill interactive script job `xcdevice observe` processes on tool/daemon shutdown (flutter/flutter#157646) 2024-11-05 [email protected] Fix: Gap between prefix and suffix icon and input field in input decoâ�¦ (flutter/flutter#152069) 2024-11-05 [email protected] Roll Flutter Engine from f56401062e42 to e5e06c97c33c (1 revision) (flutter/flutter#158194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 5, 2024

test: Add test for raw_scrollbar.2.dart

0f19831

ValentinVignal force-pushed the flutter/examples/api/Add-test-for-raw-scrollbar-2 branch from 4c6bcf6 to 0f19831 Compare November 5, 2024 09:43

ValentinVignal requested a review from bleroux November 5, 2024 09:43

bleroux approved these changes Nov 5, 2024

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2024

auto-submit Bot merged commit ffe81f0 into flutter:master Nov 5, 2024

engine-flutter-autoroll mentioned this pull request Nov 6, 2024

Roll Flutter from 29d40f7f6826 to 73546b3b71a7 (20 revisions) flutter/packages#8028

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2024

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

cbbb1bf

Piinks mentioned this pull request Nov 8, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

b7f95dd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

3dc5be2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

5f5e226

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

7b207a2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

ffe81f0 Add test for raw_scrollbar.2.dart (flutter/flutter#158161)

2e4607e

Navigation Menu

Repository navigation

Add test for `raw_scrollbar.2.dart` - #158161

Add test for `raw_scrollbar.2.dart`#158161
auto-submit[bot] merged 1 commit into
flutter:masterfrom
ValentinVignal:flutter/examples/api/Add-test-for-raw-scrollbar-2

ValentinVignal commented Nov 5, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Nov 5, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ValentinVignal commented Nov 5, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bleroux Nov 5, 2024 •

edited

Loading