Skip to content

Add a simple golden-file test to package:integration_test. - #159233

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
matanlurey:add-integration-test-golden-test
Dec 9, 2024
Merged

Add a simple golden-file test to package:integration_test.#159233
auto-submit[bot] merged 7 commits into
flutter:masterfrom
matanlurey:add-integration-test-golden-test

Conversation

@matanlurey

@matanlurey matanlurey commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Closes #72045.

Let's see if I wired this correctly and if Flutter Gold knows to check based on the files changed.

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Nov 21, 2024
@matanlurey
matanlurey requested a review from cbracken November 21, 2024 00:14
@cbracken

cbracken commented Nov 21, 2024

Copy link
Copy Markdown
Member 
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ /b/s/w/ir/x/w/flutter/packages/integration_test/test/golden_screenshot_test.dart: Files containing golden tests must be tagged using @Tags(<String>['reduced-test-set']) at the top of the file before import statements.
║ See: https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Writing-a-golden-file-test-for-package-flutter.md
╚═══════════════════════════════════════════════════════════════════════════════

@matanlurey

matanlurey commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

Mean.

cbracken
cbracken approved these changes Nov 21, 2024
View reviewed changes

@cbracken cbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May the force be with you.

@joelibaceta

This comment was marked as off-topic.

Sign in to view
@flutter-dashboard

flutter-dashboard Bot commented Dec 9, 2024

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #159233 at sha 572a69c

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Dec 9, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@auto-submit
auto-submit Bot added this pull request to the merge queue Dec 9, 2024
Merged via the queue into flutter:master with commit 48c2301 Dec 9, 2024
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@matanlurey
matanlurey deleted the add-integration-test-golden-test branch December 9, 2024 20:02
@Piinks

Piinks commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

if Flutter Gold knows to check based on the files changed.

The flutter-gold check from flutter/cocoon does not consider what files changed, it looks at what test shards are running. It may need to be informed of what test shards package:integration_test runs on for it to guard against PRs landing with images changes.

https://github.com/flutter/cocoon/blob/f12111463c23852d0f83049af985dc43f0f422a4/app_dart/lib/src/request_handlers/push_gold_status_to_github.dart#L126

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
eec1103 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
95af4c8 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
fa334ff 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
29a7a67 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
c5ac01a 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
ef0ef01 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
ed927f3 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
a714d9f 
…lutter/flutter#159233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
31eaca2 
…lutter/flutter#159233)
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
9 of 11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
13c5ee4 
…lutter/flutter#159233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
7f87cde 
…lutter/flutter#159233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
2354800 
…lutter/flutter#159233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
27edd70 
…lutter/flutter#159233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
48c2301 Add a simple golden-file test to package:integration_test. (f…
df6b4f6 
…lutter/flutter#159233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Skia Gold support to tests for package:integration_test

4 participants

@matanlurey @cbracken @joelibaceta @Piinks