Skip to content

Fix SafeArea DartPad sample - #159344

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
nate-thegrate:fix-safearea-example
Dec 9, 2024
Merged

auto-submit[bot] merged 3 commits into
flutter:masterfrom
nate-thegrate:fix-safearea-example

Conversation

@nate-thegrate

Copy link
Copy Markdown
Contributor

This pull request fixes a bug I introduced in #158019.


Before

RenderFlex overflowed

After

RenderFlex overflowed



@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 22, 2024
@goderbauer
goderbauer requested a review from chunhtai November 26, 2024 23:05
Text(label),
Builder(
builder: (BuildContext context) => Slider(
key: ValueKey<Inset>(this),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it to make the testing easier… now that you mention it, I could probably just loop through every slider that the finder returns.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factored this out in dfef025!

@nate-thegrate
nate-thegrate marked this pull request as draft November 27, 2024 22:32
@nate-thegrate
nate-thegrate marked this pull request as ready for review December 3, 2024 00:07

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@auto-submit
auto-submit Bot added this pull request to the merge queue Dec 9, 2024
Merged via the queue into flutter:master with commit dc58093 Dec 9, 2024
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@nate-thegrate
nate-thegrate deleted the fix-safearea-example branch December 9, 2024 19:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
9 of 11 tasks
@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SafeArea code sample not rendering properly

2 participants