Skip to content

Make sure flutter update-packages --verify-only has a non-zero exit code - #15962

Merged
jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:make_sure_fails
Mar 30, 2018
Merged

jonahwilliams merged 3 commits into
flutter:masterfrom
jonahwilliams:make_sure_fails

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Also fixes typo in message. Required to make analysis fail for flutter build

@tvolkert tvolkert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
jonahwilliams merged commit cfda7a6 into flutter:master Mar 30, 2018
@jonahwilliams
jonahwilliams deleted the make_sure_fails branch March 30, 2018 03:34
@cbracken

Copy link
Copy Markdown
Member

This appears to have broken Travis and Appveyor at head.

tvolkert added a commit that referenced this pull request Mar 30, 2018
tvolkert added a commit that referenced this pull request Mar 30, 2018
@tvolkert

Copy link
Copy Markdown
Contributor

Reverted

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

I continue to be reminded that travis is not tap 🥇

@cbracken

cbracken commented Mar 30, 2018 •

Copy link
Copy Markdown
Member

Not having TAP is the best (possibly only) way to truly appreciate the miracle of TAP.

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
… code (flutter#15962)

* make sure --verify-only logs error messages and fix typo

* ensure non zero exit code

* undo random pubspec change
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants