[CP-stable]Migrate module templates to declarative application of the Flutter Gradle Plugin by flutteractionsbot · Pull Request #160090 · flutter/flutter

flutteractionsbot · 2024-12-11T15:17:41Z

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#159729

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

#159729: Warning in logs after a fresh flutter module create when building an aar for android.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Warning after flutter create of a module.

Workaround:

Is there a workaround for this issue?

Manual migration after flutter create.

Risk:

What is the risk level of this cherry-pick?

Low
Medium
High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

Yes
No

Validation Steps:

What are the steps to validate that this fix works?

create module then build as app or aar then look in logs for warnings about gradle imperative apply

…adle Plugin (flutter#159770) Fixes flutter#159729 Cases to consider: 1. Building the module as a standalone app (`flutter run`) 2. Building the module as an aar (`flutter build aar`) 3. Doing (2) and then building an android host app that depends on the aar. 4. Building the host app with it depending on the module as source. Manually tested all 4 and they all are working. Modified `build_android_host_app_with_module_aar.dart` and `build_android_host_app_with_module_source.dart` to add checks on `stderr` to ensure we don't hit the log. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>

flutteractionsbot · 2024-12-11T15:17:43Z

@reidbaker please fill out the PR description above, afterwards the release team will review this request.

christopherfujino · 2024-12-12T18:17:01Z

We have some build failures here:

[2024-12-11 07:22:11.288404] [STDOUT] stdout:            * What went wrong:
[2024-12-11 07:22:11.288539] [STDOUT] stdout:            An exception occurred applying plugin request [id: 'com.android.library']
[2024-12-11 07:22:11.288661] [STDOUT] stdout:            > Failed to apply plugin 'com.android.internal.library'.
[2024-12-11 07:22:11.288784] [STDOUT] stdout:               > Could not create plugin of type 'LibraryPlugin'.
[2024-12-11 07:22:11.289070] [STDOUT] stdout:                  > Could not generate a decorated class for type LibraryPlugin.
[2024-12-11 07:22:11.289192] [STDOUT] stdout:                     > org/gradle/api/configuration/BuildFeatures

[2024-12-11 07:22:11.289504] [STDOUT] stdout:            * Exception is:
[2024-12-11 07:22:11.289541] [STDOUT] stdout:            org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'com.android.library']

From: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_aar_module_test/18199/infra

gmackall · 2024-12-12T18:20:17Z

We have some build failures here:

[2024-12-11 07:22:11.288404] [STDOUT] stdout:            * What went wrong:
[2024-12-11 07:22:11.288539] [STDOUT] stdout:            An exception occurred applying plugin request [id: 'com.android.library']
[2024-12-11 07:22:11.288661] [STDOUT] stdout:            > Failed to apply plugin 'com.android.internal.library'.
[2024-12-11 07:22:11.288784] [STDOUT] stdout:               > Could not create plugin of type 'LibraryPlugin'.
[2024-12-11 07:22:11.289070] [STDOUT] stdout:                  > Could not generate a decorated class for type LibraryPlugin.
[2024-12-11 07:22:11.289192] [STDOUT] stdout:                     > org/gradle/api/configuration/BuildFeatures

[2024-12-11 07:22:11.289504] [STDOUT] stdout:            * Exception is:
[2024-12-11 07:22:11.289541] [STDOUT] stdout:            org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'com.android.library']

From: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_aar_module_test/18199/infra

I believe this should be fixed by #160108

reidbaker · 2024-12-12T18:20:46Z

We have some build failures here:

[2024-12-11 07:22:11.288404] [STDOUT] stdout:            * What went wrong:
[2024-12-11 07:22:11.288539] [STDOUT] stdout:            An exception occurred applying plugin request [id: 'com.android.library']
[2024-12-11 07:22:11.288661] [STDOUT] stdout:            > Failed to apply plugin 'com.android.internal.library'.
[2024-12-11 07:22:11.288784] [STDOUT] stdout:               > Could not create plugin of type 'LibraryPlugin'.
[2024-12-11 07:22:11.289070] [STDOUT] stdout:                  > Could not generate a decorated class for type LibraryPlugin.
[2024-12-11 07:22:11.289192] [STDOUT] stdout:                     > org/gradle/api/configuration/BuildFeatures

[2024-12-11 07:22:11.289504] [STDOUT] stdout:            * Exception is:
[2024-12-11 07:22:11.289541] [STDOUT] stdout:            org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'com.android.library']

From: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_aar_module_test/18199/infra

I will stack #160108 on top of this pr once it is landed.

itsjustkevin · 2024-12-16T19:11:17Z

flutter-3.27-candidate.0 is no longer the beta branch.

…ates (flutter#160108) flutter#159770 regressed the module templates to use a hardcoded `8.7.0` and `1.8.22` as the AGP and Kotlin versions respectively. This PR returns them to using the template context values. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>

reidbaker · 2024-12-16T20:03:09Z

flutter-3.27-candidate.0 is no longer the beta branch.

We still want this targeting 3.27

…32b173fe0cb017d2d3a9b3ef

christopherfujino

LGTM

…n of the Flutter Gradle Plugin (flutter/flutter#160090)

flutteractionsbot added the cp: review Cherry-picks in the review queue label Dec 11, 2024

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 11, 2024

reidbaker requested review from christopherfujino, gmackall and reidbaker December 11, 2024 15:23

Merge branch 'flutter-3.27-candidate.0' into cp-beta-2afaa619cbb369b0…

5ed5b19

…32b173fe0cb017d2d3a9b3ef

reidbaker approved these changes Dec 16, 2024

View reviewed changes

itsjustkevin changed the title ~~[CP-beta]Migrate module templates to declarative application of the Flutter Gradle Plugin~~ [CP-stable]Migrate module templates to declarative application of the Flutter Gradle Plugin Dec 16, 2024

christopherfujino approved these changes Jan 9, 2025

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

auto-submit Bot merged commit 4429073 into flutter:flutter-3.27-candidate.0 Jan 9, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

4429073 [CP-stable]Migrate module templates to declarative applicatio…

77442cb

…n of the Flutter Gradle Plugin (flutter/flutter#160090)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

4429073 [CP-stable]Migrate module templates to declarative applicatio…

987a538

…n of the Flutter Gradle Plugin (flutter/flutter#160090)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

4429073 [CP-stable]Migrate module templates to declarative applicatio…

117d9e9

…n of the Flutter Gradle Plugin (flutter/flutter#160090)

flutteractionsbot deleted the cp-beta-2afaa619cbb369b032b173fe0cb017d2d3a9b3ef branch July 20, 2026 17:01

Navigation Menu

Repository navigation

[CP-stable]Migrate module templates to declarative application of the Flutter Gradle Plugin - #160090

[CP-stable]Migrate module templates to declarative application of the Flutter Gradle Plugin#160090
auto-submit[bot] merged 3 commits into
flutter:flutter-3.27-candidate.0from
flutteractionsbot:cp-beta-2afaa619cbb369b032b173fe0cb017d2d3a9b3ef

flutteractionsbot commented Dec 11, 2024 •

edited by reidbaker

Loading

Uh oh!

flutteractionsbot commented Dec 11, 2024

Uh oh!

christopherfujino commented Dec 12, 2024

Uh oh!

gmackall commented Dec 12, 2024

Uh oh!

reidbaker commented Dec 12, 2024

Uh oh!

itsjustkevin commented Dec 16, 2024

Uh oh!

reidbaker commented Dec 16, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

flutteractionsbot commented Dec 11, 2024 • edited by reidbaker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Link:

Changelog Description:

Impact Description:

Workaround:

Risk:

Test Coverage:

Validation Steps:

Uh oh!

flutteractionsbot commented Dec 11, 2024

Uh oh!

christopherfujino commented Dec 12, 2024

Uh oh!

gmackall commented Dec 12, 2024

Uh oh!

reidbaker commented Dec 12, 2024

Uh oh!

itsjustkevin commented Dec 16, 2024

Uh oh!

reidbaker commented Dec 16, 2024

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flutteractionsbot commented Dec 11, 2024 •

edited by reidbaker

Loading