Skip to content

Set java 11 as expected java version in all templates - #160349

Merged
auto-submit[bot] merged 9 commits into
masterfrom
i156111-java-17-template-update
Jan 7, 2025
Merged

Set java 11 as expected java version in all templates#160349
auto-submit[bot] merged 9 commits into
masterfrom
i156111-java-17-template-update

Conversation

@reidbaker

@reidbaker reidbaker commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bump templates from java 8 to java 11.

fixes #156111

I want to talk to @gmackall before merging to talk through the consequences.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 16, 2024
@flutter-dashboard

flutter-dashboard Bot commented Dec 16, 2024

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@reidbaker
reidbaker requested a review from gmackall December 16, 2024 15:58
@reidbaker reidbaker changed the title Set java 17 as expected java version Set java 11 as expected java version in all templates Dec 17, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit

auto-submit Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/160349, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit

auto-submit Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/160349, due to - The status or check suite Windows build_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit b552906 Jan 7, 2025
@auto-submit
auto-submit Bot deleted the i156111-java-17-template-update branch January 7, 2025 16:01
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
32f590e 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
e79f60b 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
d590fc5 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
3ab618f 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
90e00ae 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
f688ffa 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
95855a1 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
d208da9 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
b876dee 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
6ba0a21 
…r/flutter#160349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
796bab0 
…r/flutter#160349)
@FrankenApps FrankenApps mentioned this pull request Jan 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
d302f75 
…r/flutter#160349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
b719f36 
…r/flutter#160349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
6e5108b 
…r/flutter#160349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
4e7a1af 
…r/flutter#160349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
b552906 Set java 11 as expected java version in all templates (flutte…
f12e345 
…r/flutter#160349)
@OutdatedGuy OutdatedGuy mentioned this pull request Apr 9, 2025
Closed
1 task done
@FrankenApps FrankenApps mentioned this pull request Jun 4, 2025
Merged
@FrankenApps FrankenApps mentioned this pull request Dec 14, 2025
Merged
chrisbobbe pushed a commit to rajveermalviya/zulip-flutter that referenced this pull request Sep 29, 2026
@rajveermalviya @claude @chrisbobbe
android build: Target Java 17, from Java 8
bf7a5b7 
This matches the upstream template:
  flutter/flutter#160349
  flutter/flutter#176203
and resolves javac's warnings on our own code that source and target
value 8 are obsolete.  CI already builds with JDK 17, and
docs/setup.md asks for it.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes
@bartekpacia bartekpacia bartekpacia approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android build warnings about Java with latest Gradle: source value 8 is obsolete/target value 8 is obsolete

3 participants

@reidbaker @gmackall @bartekpacia