Feature/twitter keyboard by NabilaWorks · Pull Request #161025 · flutter/flutter

NabilaWorks · 2024-12-31T19:44:04Z

Example :

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Centered TextField Example',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: CenteredTextFieldScreen(),
    );
  }
}

class CenteredTextFieldScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Centered TextField')),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(16.0),
          child: TextField(
            keyboardType: TextInputType.twitter,
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              hintText: 'Enter some text here',
            ),
          ),
        ),
      ),
    );
  }
}

iPhoneTwitter.MP4

iPadTwitter.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM from the text input team's point of view 👍. Thank you @NabilaWorks for jumping in to add support for this!

Probably someone more familiar with iOS and Android should take a look at those respective parts of the PR before merging. CC @reidbaker @jmagman

For Android, @reidbaker can you confirm that TYPE_TEXT_VARIATION_EMAIL_ADDRESS is the best match for this?

Edit: Also I wanted to point out how nice it is to have this change all in one PR thanks to the monorepo!

jmagman · 2025-01-06T20:46:59Z

Thank you @NabilaWorks! If you're feeling inspired, there are likely more missing keyboards 😉 #127831

Probably someone more familiar with iOS and Android should take a look at those respective parts of the PR before merging.

@hellohuanlin can you take a look?

jmagman · 2025-01-07T18:40:41Z

For Android, @reidbaker can you confirm that TYPE_TEXT_VARIATION_EMAIL_ADDRESS is the best match for this?

Adding @reidbaker as a reviewer.

reidbaker

After reading through https://developer.android.com/reference/android/text/InputType I think email is the best fit since it will have an @ char.

flutter/flutter@40c2b86...5517cc9 2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680) 2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643) 2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632) 2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@40c2b86...5517cc9 2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680) 2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 [email protected] Roll Packages from 708b585 to d4bc414 (2 revisions) (flutter/flutter#161672) 2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643) 2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632) 2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

NabilaWorks added 10 commits January 1, 2025 01:49

UIKeyboardTypeTwitter for iOS

a53d151

testKeyboardTypeTwitter for iOS

5ac3589

TextInputType.TWITTER for Android

af800b9

Map TextInputType.TWITTER to EMAIL_ADDRESS

08f2c1a

test textInputTypeTwitter for Android

59c4d55

added TextInputType.twitter

c328151

test TextInputType.twitter

556c6e8

fix whitespace

3cbdf5c

added trailing comma

eddd0c2

fix .java formatting

98bd7fa

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. labels Dec 31, 2024

justinmc approved these changes Jan 2, 2025

View reviewed changes

NabilaWorks added 2 commits January 3, 2025 13:06

Merge branch 'master' into feature/twitter_keyboard

75a4967

Merge branch 'master' into feature/twitter_keyboard

e58c67d

jmagman requested a review from hellohuanlin January 6, 2025 20:47

jmagman mentioned this pull request Jan 6, 2025

TextField keyboardType missing UIKeyboardTypeASCIICapable for iOS #127831

Open

2 tasks done

hellohuanlin approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'master' into feature/twitter_keyboard

3a1b389

jmagman requested a review from reidbaker January 7, 2025 18:40

Merge branch 'master' into feature/twitter_keyboard

31713cd

github-actions Bot added platform-android Android applications specifically platform-ios iOS applications specifically labels Jan 7, 2025

NabilaWorks added 3 commits January 8, 2025 12:44

Merge branch 'master' into feature/twitter_keyboard

f4347bd

Merge branch 'master' into feature/twitter_keyboard

411d9bc

Merge branch 'master' into feature/twitter_keyboard

591d0aa

reidbaker approved these changes Jan 10, 2025

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

90f60f8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

1035d03

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

10eacc2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

e4307c9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

29d110e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

cbf1deb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

f064b23

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

85df5b4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

3f892f7

Piinks mentioned this pull request Jan 17, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

ca51d94

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

4e7fac3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

a591f26

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

606d5a9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e0d7b58 Feature/twitter keyboard (flutter/flutter#161025)

228d00b

seungsoo47 mentioned this pull request Apr 24, 2025

Add Twitter/WebSearch Keyboard flutter-tizen/embedder#87

Merged

Navigation Menu

Repository navigation

Feature/twitter keyboard - #161025

Feature/twitter keyboard#161025
auto-submit[bot] merged 18 commits into
flutter:masterfrom
NabilaWorks:feature/twitter_keyboard

NabilaWorks commented Dec 31, 2024

Uh oh!

justinmc left a comment •

edited

Loading

Uh oh!

jmagman commented Jan 6, 2025

Uh oh!

jmagman commented Jan 7, 2025

Uh oh!

reidbaker left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

NabilaWorks commented Dec 31, 2024

Pre-launch Checklist

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jan 6, 2025

Uh oh!

jmagman commented Jan 7, 2025

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinmc left a comment •

edited

Loading