Repository navigation
[Android] Add .cxx directories to app template .gitignore - #161069
Conversation
02301b0 to
b51964f
Compare
gnprice
left a comment
There was a problem hiding this comment.
Thanks!
One nit below. I also did a quick search for existing gitignore files this should perhaps be added to:
$ git ls-files | grep android/.gitignore
Other than the ones already in this PR, that finds:
engine/src/flutter/shell/platform/android/.gitignore
engine/src/flutter/testing/scenario_app/android/.gitignore
packages/integration_test/android/.gitignore
I think the second one is a true match that should get this change. The third I'm not sure about. The first is a false positive.
Oh and this search for relevant templates:
$ git ls-files packages/flutter_tools/ | grep android.*gitignore
packages/flutter_tools/templates/app/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore
The app/ one is included here, and plugin_shared/ already has this line. I don't understand the difference between plugin/ and plugin_shared/ — should plugin/ get this too?
Co-authored-by: Greg Price <[email protected]>
Also added to the |
Fixes (but I still need to write the draft of the blog section so don't autoclose github 🙏 ) #160372.
-Module templates already exclude the entire
.androiddirectory.-Plugin templates already exclude
.cxx.Modified the existing gitignores with
(which was probably not the best way)
Fun fact: apparently the
.gitignorefiles (including the ones we copy to the template apps) aren't indexed for search (the.gitignore.tmplare, but not the ones that we copy exactly such as this one).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.