Skip to content

Add _PointerState#toString - #16197

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:pointer_state
Apr 4, 2018
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:pointer_state

Conversation

@abarth

@abarth abarth commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

This method makes it easier to debug issues involving broken pointer
states.

This method makes it easier to debug issues involving broken pointer
states.
@abarth
abarth requested a review from Hixie April 3, 2018 19:35
@abarth
abarth requested a review from chinmaygarde April 4, 2018 00:02
@gspencergoog

Copy link
Copy Markdown
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@abarth
abarth merged commit 3ff25c7 into flutter:master Apr 4, 2018
@abarth
abarth deleted the pointer_state branch April 4, 2018 16:04
@Hixie

Hixie commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

for future reference, we usually use $runtimeType rather than hard-coding the type in the toString, because that way if anyone ever subclasses the class, they won't be misled by the toString. (But that doesn't matter in this case since it's private anyway.)

teriyakijack pushed a commit to teriyakijack/flutter that referenced this pull request Apr 5, 2018
* upstream/master:
  Run test coverage in dart2 again (flutter#15932)
  Roll engine to 23c0b7b (flutter#16254)
  fix date/time picker borders (flutter#16240)
  Revert "Roll engine to version 58d6ea3 (flutter#16236)" (flutter#16252)
  Roll engine to version 58d6ea3 (flutter#16236)
  Add disable Cupertino Switch example (flutter#15853)
  Roll engine to ac40891 (flutter#16232)
  re-enable verify only test failure and update deps. (flutter#16090)
  Extract checking IntelliJ packages into a helper and use for Android Studio. (flutter#16198)
  Remove DevToolsSecurity check from initial flutter doctor (flutter#16007)
  export RawKeyEvent from RawKeyboardListener (flutter#15956)
  Revert "Adds Java EE module to SDK manager calls" (flutter#16227)
  update intellij metadata in template files (flutter#16211)
  Add _PointerState#toString (flutter#16197)
  add a period after xcode build done (flutter#16209)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
This method makes it easier to debug issues involving broken pointer
states.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants