Skip to content

Add a data driven fix for InputDecoration.maintainHintHeight - #162600

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_dart_fix_for_InputDecoration_maintainHintHeight
Feb 5, 2025
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_dart_fix_for_InputDecoration_maintainHintHeight

Conversation

@bleroux

@bleroux bleroux commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds a dart fix to migrate from InputDecoration.maintainHintHeight to InputDecoration.maintainHintSize.

Related PR

Follow up to #161235

Tests

Adds 1 test.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages c: tech-debt Technical debt, code quality, testing, etc. labels Feb 3, 2025
@bleroux
bleroux force-pushed the add_dart_fix_for_InputDecoration_maintainHintHeight branch from cc0e3d3 to 17d0aba Compare February 4, 2025 14:23
@bleroux
bleroux force-pushed the add_dart_fix_for_InputDecoration_maintainHintHeight branch from 17d0aba to c710231 Compare February 4, 2025 18:38
@bleroux
bleroux requested a review from justinmc February 4, 2025 20:22

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for following up with this, I didn't think of it during the original PR.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@bleroux bleroux added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Feb 5, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit 65124c5 Feb 5, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@bleroux
bleroux deleted the add_dart_fix_for_InputDecoration_maintainHintHeight branch February 6, 2025 06:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
antfitch pushed a commit to flutter/website that referenced this pull request Feb 28, 2025
…11742)

This PR adds a migration guide for inputDecoration.maintainHintHeight.

Related PRs:
- flutter/flutter#161235
- dart fix: flutter/flutter#162600

## Presubmit checklist

- [ ] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [X] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [X] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [X] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants