Skip to content

chore(canvaskit): remove SurfaceFrame from Surface - #162825

Merged
auto-submit[bot] merged 8 commits into
flutter:masterfrom
harryterkelsen:canvaskit-surface-remove-surfaceframe
Feb 7, 2025
Merged

chore(canvaskit): remove SurfaceFrame from Surface#162825
auto-submit[bot] merged 8 commits into
flutter:masterfrom
harryterkelsen:canvaskit-surface-remove-surfaceframe

Conversation

@harryterkelsen

@harryterkelsen harryterkelsen commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

SurfaceFrame is no longer used. This is a cleanup in preparation for a larger refactor of Surface to improve performance.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Feb 6, 2025
yjbanov
yjbanov approved these changes Feb 6, 2025
View reviewed changes

@yjbanov yjbanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/surface.dart Outdated
@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit

auto-submit Bot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/162825, because - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Feb 6, 2025
Merged via the queue into flutter:master with commit db7e82b Feb 7, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
9f3808e 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
b2ad953 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
00278a1 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
226ff72 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
06c119a 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
4a7a716 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
9d1e7aa 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
832b927 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
691cb8e 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
7fc0b30 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
56d96f6 
…lutter#162825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
4014829 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
9818b8a 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
e75358d 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
e784031 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
6b800e6 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
9f71ea4 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
ea33fc3 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
dbf7ab3 
…lutter#162825)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
db7e82b chore(canvaskit): remove SurfaceFrame from Surface (flutter/f…
5885b1e 
…lutter#162825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @yjbanov