Repository navigation
fix(doctor): add an alternative path for the Dart plugin - #163215
Conversation
619d669 to
471dd27
Compare
|
@jwren can you take a look at this? It seems strange that we'd be seeing lowercase |
|
This is surprising, the Dart plugin for IntelliJ has always been "Dart", see the bottom of https://plugins.jetbrains.com/plugin/6351-dart. @alexander-dorosko -- any idea why this might be different for some users? |
I don't think that's relevant. For example, the plugin ID for Flutter is "io.flutter", yet the directory containing it is called "flutter-intellij" For additional context, this happened after I wiped my desktop, so after a clean OS install, clean Android Studio install and clean plugin install. I don't know if an update would cause this directory to be renamed, but a clean install sure did create it lowercased. |
|
Hi @bkonyi, just checking in to see if there are any updates or if anything else is needed from my side to move this forward. Thanks! |
|
Sorry for the delay! This LGTM if @jwren has no concerns. |
|
autosubmit label was removed for flutter/flutter/163215, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
|
@jwren this needs a second reviewer. Can I get your rubber stamp? |
It seems like with some recent plugin/IDE version, the path for the Dart plugin has changed from `<base path>/Dart` to `<base path>/dart`, causing `flutter doctor` to incorrectly assume that the plugin is not installed. Add `dart` as an alternative to the existing `Dart` package name. Fixes: flutter#163214
471dd27 to
cf7a2a5
Compare
) It seems like with some recent plugin/IDE version, the path for the Dart plugin has changed from `<base path>/Dart` to `<base path>/dart`, causing `flutter doctor` to incorrectly assume that the plugin is not installed. Add `dart` as an alternative to the existing `Dart` package name. Fixes flutter#163214. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
It seems like with some recent plugin/IDE version, the path for the Dart plugin has changed from
<base path>/Dartto<base path>/dart, causingflutter doctorto incorrectly assume that the plugin is not installed.Add
dartas an alternative to the existingDartpackage name.Fixes #163214.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.