Skip to content

Remove the last vestiges of null-unsafety in flutter_tools. - #164026

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
matanlurey:x-null-safety
Feb 27, 2025
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
matanlurey:x-null-safety

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

The internal code using this was deleted in cl/730558889.

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Feb 24, 2025

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov changed the title Remove the last vestiges of null-safety in flutter_tools. Remove the last vestiges of null-unsafety in flutter_tools. Feb 24, 2025

@srujzs srujzs left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this had already landed - sorry for the late review! LGTM

Comment thread packages/flutter_tools/lib/src/web/bootstrap.dart
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025
@auto-submit

auto-submit Bot commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/164026, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Feb 27, 2025
Merged via the queue into flutter:master with commit d8856b9 Feb 27, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@jiahaog jiahaog mentioned this pull request Mar 3, 2025
5 of 9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants