Repository navigation
Cleanup FLX related code - #16416
Merged
Merged
Cleanup FLX related code#16416
Conversation
mravn-google
approved these changes
Apr 10, 2018
Contributor
There was a problem hiding this comment.
We don't usually update these. I don't think it makes a difference that we rename the file.
szakarias
force-pushed
the
newFlxCleanup
branch
from
April 12, 2018 07:40
001431e to
786aa4e
Compare
This was referenced Apr 12, 2018
aam
reviewed
Apr 12, 2018
| } | ||
|
|
||
| FlutterTask flutterTask = project.tasks.create(name: "flutterBuild${variant.name.capitalize()}", type: FlutterTask) { | ||
| dependsOn dependenciesTask |
Member
There was a problem hiding this comment.
Do you know what was the purpose of flutterDependencies task? It sounds like it was to generate initial dependency file for this flutterBuild task, so that flutterBuild task can be skipped if sources haven't changed.
Contributor
There was a problem hiding this comment.
That was the purpose, yes, but since then some other changes were made to Flutter Tools, so it now also checks if the source files have changed before building a new snapshot. So it's no longer necessary to do a double build in Gradle anymore.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change
flutter build flxoptionflutter build bundleoption