Skip to content

[Impeller] tear down swapchain when backgrounding. - #165259

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
jonahwilliams:swapchain_count
Mar 18, 2025
Merged

[Impeller] tear down swapchain when backgrounding.#165259
auto-submit[bot] merged 4 commits into
flutter:masterfrom
jonahwilliams:swapchain_count

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Mar 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

When we return to the foreground the swapchain is reconstructed anyway. Eagerly tearing the old one down releases memory faster. Highlighted by a regression in a customer: money benchmark.

@github-actions github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 15, 2025
@jonahwilliams
jonahwilliams marked this pull request as ready for review March 17, 2025 15:57
@jonahwilliams

jonahwilliams commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

This should show up in our memory benchmarks

@jonahwilliams
jonahwilliams requested a review from gaaclarke March 17, 2025 16:27
gaaclarke
gaaclarke reviewed Mar 17, 2025
View reviewed changes

@gaaclarke gaaclarke left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is simple and looks good to me. There is a mechanism outside of this PR that resurrects the swapchain. I'd love to have a test that exercises that. Maybe in the android view level?

At a minimum we should have a comment that explains the mechanism that resurrects the swapchain.

Comment thread engine/src/flutter/impeller/renderer/backend/vulkan/surface_context_vk.cc
}

void SurfaceContextVK::TeardownSwapchain() {
swapchain_.reset();

@gaaclarke gaaclarke Mar 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth commenting how this will get resurrected.

@jonahwilliams

jonahwilliams commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

There is a mechanism outside of this PR that resurrects the swapchain. I'd love to have a test that exercises that. Maybe in the android view level?

THe android engine tests background and foreground and test rendering. I think those will cover it

@jonahwilliams

jonahwilliams commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

Added unit test and doc comment.

gaaclarke
gaaclarke approved these changes Mar 18, 2025
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit

auto-submit Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/165259, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit 05c868e Mar 18, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
1c80e2b 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
64ae4d7 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
c7d08de 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
cdc7823 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
cc70d9e 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
41b9832 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
4ca6d37 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
ef5df22 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
2fffe30 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
91db011 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
8b2b3b5 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
771417a 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
79c60ca 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
9dacd6f 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
73447c8 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
564312c 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
e9dec8d 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
f6883fb 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
74034e4 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
cbd5a2f 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
5a697eb 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
1b08e39 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
703b780 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
4495c15 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
cb6af4d 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
b8d1104 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
bff23e0 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
379954e 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
33a6833 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
edae6ba 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
27fac1b 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
eec69ed 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
be63120 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
28230b0 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
d427e42 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
952eeb6 
…lutter#165259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
05c868e [Impeller] tear down swapchain when backgrounding. (flutter/f…
24a2683 
…lutter#165259)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
Jonah Williams @romanejaquez
[Impeller] tear down swapchain when backgrounding. (flutter#165259)
3b1c503 
When we return to the foreground the swapchain is reconstructed anyway.
Eagerly tearing the old one down releases memory faster. Highlighted by
a regression in a customer: money benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. platform-android Android applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke