Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" by bkonyi · Pull Request #166016 · flutter/flutter

bkonyi · 2025-03-26T20:49:11Z

Reason for revert: multiple gradlew failures on devicelab tests

This reverts commit c376ca2.

matanlurey

LGTM

flutter-dashboard · 2025-03-26T20:50:56Z

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

) This reverts commit 8dccbc3.

flutter/flutter#166016)

) (#166059) This reverts commit 8dccbc3. Find/replace didn't catch the use of `jvmTarget = "1.8"` in `dev/integration_tests/android_engine_test/android/app/build.gradle` and `android_engine_test` needed to have `"com.android.application"` updated.

flutter/flutter#166016)

…er#166016) Reverts flutter#165987 Reason for revert: multiple gradlew failures on devicelab tests

…ter#166016) (flutter#166059) This reverts commit flutter@8dccbc3. Find/replace didn't catch the use of `jvmTarget = "1.8"` in `dev/integration_tests/android_engine_test/android/app/build.gradle` and `android_engine_test` needed to have `"com.android.application"` updated.

…er#166016) Reverts flutter#165987 Reason for revert: multiple gradlew failures on devicelab tests

…ter#166016) (flutter#166059) This reverts commit flutter@8dccbc3. Find/replace didn't catch the use of `jvmTarget = "1.8"` in `dev/integration_tests/android_engine_test/android/app/build.gradle` and `android_engine_test` needed to have `"com.android.application"` updated.

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18 (#165987)"

a56f572

This reverts commit c376ca2.

bkonyi requested a review from matanlurey as a code owner March 26, 2025 20:49

matanlurey approved these changes Mar 26, 2025

View reviewed changes

matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Mar 26, 2025

matanlurey added this pull request to the merge queue Mar 26, 2025

bkonyi mentioned this pull request Mar 26, 2025

Reverts "[ Device Lab ] Upgrade Device Lab projects to Java 18 (#165987)" #166017

Closed

Merged via the queue into master with commit 8dccbc3 Mar 26, 2025

matanlurey deleted the revert-165987-fix_source_value_8 branch March 26, 2025 21:24

bkonyi added a commit that referenced this pull request Mar 27, 2025

Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016

27cd5dc

) This reverts commit 8dccbc3.

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 2befeb9e0485 (298 revisions) flutter/packages#8913

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

609161a

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 7cb926a33d8e (299 revisions) flutter/packages#8914

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

9024226

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 31ed3b7b83b4 (300 revisions) flutter/packages#8915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

c2a0667

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to e17287da31b1 (301 revisions) flutter/packages#8916

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

85f52c5

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to caa68fc67962 (302 revisions) flutter/packages#8917

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

5d8355b

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 16fc684886a1 (303 revisions) flutter/packages#8919

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

f089dd7

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from b16430b2fd57 to 228a01170724 (317 revisions) flutter/packages#8925

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

2554104

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to ffcc383848a0 (204 revisions) flutter/packages#8926

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

731f411

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to 943dd30bfd27 (208 revisions) flutter/packages#8927

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

52739e5

flutter/flutter#166016)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to 7cfaf04fa978 (209 revisions) flutter/packages#8929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

a2ada0e

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

3dca68e

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

23fc7d8

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

4e7b352

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

6ab59dd

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

aed1b0c

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

1c8c973

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

5eee470

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

38c01d4

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

5ac66e1

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

4e4e935

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

f25e84c

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

d85275a

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

f524f5d

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

7cfc9f1

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

07f05c5

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

66ff46e

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

43f7d20

flutter/flutter#166016)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (

391839b

flutter/flutter#166016)

zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flutt…

326c953

…er#166016) Reverts flutter#165987 Reason for revert: multiple gradlew failures on devicelab tests

romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flutt…

d764306

…er#166016) Reverts flutter#165987 Reason for revert: multiple gradlew failures on devicelab tests

Navigation Menu

Repository navigation

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" - #166016

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18"#166016
matanlurey merged 1 commit into
masterfrom
revert-165987-fix_source_value_8

bkonyi commented Mar 26, 2025

Uh oh!

matanlurey left a comment

Uh oh!

flutter-dashboard Bot commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bkonyi commented Mar 26, 2025

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants