Repository navigation
Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 - #16643
Merged
Merged
Conversation
jason-simmons
approved these changes
Apr 16, 2018
Contains the following engine commits: flutter-team-archive/engine@1bc0e1b On windows, refer to Dart snapshot directly executable. flutter-team-archive/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" flutter-team-archive/engine@4b45a53 Only make ERROR and FATAL log levels visible by default. flutter-team-archive/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling) flutter-team-archive/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 flutter-team-archive/engine@9495a52 On iOS, try to use ES3, then fall back to ES2. flutter-team-archive/engine@d6d4eec Fix broken Linux build flutter-team-archive/engine@d15dc76 Fix broken Chromebot build flutter-team-archive/engine@c17a629 Breadcrumbs to the wiki flutter-team-archive/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData() flutter-team-archive/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) flutter-team-archive/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. flutter-team-archive/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) flutter-team-archive/engine@0b7d6be Re-land "do not pause rendering when android view loses focus" flutter-team-archive/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target. flutter-team-archive/engine@570231b Specify the packages file path when running engine dart tests. flutter-team-archive/engine@0b9cef5 Minor update to README flutter-team-archive/engine@c386418 Promote line height in text style created from paragraph style flutter-team-archive/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source. flutter-team-archive/engine@58e84c8 Re-land "Support multiple shells in a single process. flutter-team-archive/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD flutter-team-archive/engine@b7358b3 libtxt: cache font families that are remapped to the default font family flutter-team-archive/engine@a530035 libtxt: fix leaks in Skia object reference counting flutter-team-archive/engine@0c74fc9 [fuchsia] Fix use-after-free flutter-team-archive/engine@b6d2dde [fuchsia] Fix build flutter-team-archive/engine@1dd1264 [async] Adapt to libasync API changes.
tvolkert
changed the title
Contributor
|
I can't tell why Appveyor builds hang. Running the same test locally is fine and the invocation exits immediately (test that a failing test fails). I have run other test targets locally using the same build variant as Appveyor and they pass as well. We have unified all test runners so now the exact same |
chinmaygarde
approved these changes
Apr 17, 2018
chinmaygarde
left a comment
chinmaygarde
left a comment
Contributor
There was a problem hiding this comment.
lgtm after reverting the verbose logging on the bots. Though we should definitely figure out a way of quickly turning these on for specific runs (or maybe even leave them on all the time?).
This reverts commit 6413882.
mravn-google
added a commit
that referenced
this pull request
Apr 17, 2018
mravn-google
added a commit
that referenced
this pull request
Apr 17, 2018
This was referenced Apr 17, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Roll engine to d6d4eec Contains the following engine commits: flutter-team-archive/engine@1bc0e1b On windows, refer to Dart snapshot directly executable. flutter-team-archive/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" flutter-team-archive/engine@4b45a53 Only make ERROR and FATAL log levels visible by default. flutter-team-archive/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling) flutter-team-archive/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 flutter-team-archive/engine@9495a52 On iOS, try to use ES3, then fall back to ES2. flutter-team-archive/engine@d6d4eec Fix broken Linux build flutter-team-archive/engine@d15dc76 Fix broken Chromebot build flutter-team-archive/engine@c17a629 Breadcrumbs to the wiki flutter-team-archive/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData() flutter-team-archive/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) flutter-team-archive/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. flutter-team-archive/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) flutter-team-archive/engine@0b7d6be Re-land "do not pause rendering when android view loses focus" flutter-team-archive/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target. flutter-team-archive/engine@570231b Specify the packages file path when running engine dart tests. flutter-team-archive/engine@0b9cef5 Minor update to README flutter-team-archive/engine@c386418 Promote line height in text style created from paragraph style flutter-team-archive/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source. flutter-team-archive/engine@58e84c8 Re-land "Support multiple shells in a single process. flutter-team-archive/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD flutter-team-archive/engine@b7358b3 libtxt: cache font families that are remapped to the default font family flutter-team-archive/engine@a530035 libtxt: fix leaks in Skia object reference counting flutter-team-archive/engine@0c74fc9 [fuchsia] Fix use-after-free flutter-team-archive/engine@b6d2dde [fuchsia] Fix build flutter-team-archive/engine@1dd1264 [async] Adapt to libasync API changes. * Run test platform finalizers in reverse order to ensure that shell is shutdown before trying to delete any temporary files or directories. This fixes "Access Denied" error on Windows (see flutter#16657).
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the following engine commits:
flutter-team-archive/engine@1bc0e1b On windows, refer to Dart snapshot directly executable.
flutter-team-archive/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79"
flutter-team-archive/engine@4b45a53 Only make ERROR and FATAL log levels visible by default.
flutter-team-archive/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling)
flutter-team-archive/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79
flutter-team-archive/engine@9495a52 On iOS, try to use ES3, then fall back to ES2.
flutter-team-archive/engine@d6d4eec Fix broken Linux build
flutter-team-archive/engine@d15dc76 Fix broken Chromebot build
flutter-team-archive/engine@c17a629 Breadcrumbs to the wiki
flutter-team-archive/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData()
flutter-team-archive/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits)
flutter-team-archive/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain.
flutter-team-archive/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits)
flutter-team-archive/engine@0b7d6be Re-land "do not pause rendering when android view loses focus"
flutter-team-archive/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target.
flutter-team-archive/engine@570231b Specify the packages file path when running engine dart tests.
flutter-team-archive/engine@0b9cef5 Minor update to README
flutter-team-archive/engine@c386418 Promote line height in text style created from paragraph style
flutter-team-archive/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source.
flutter-team-archive/engine@58e84c8 Re-land "Support multiple shells in a single process.
flutter-team-archive/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD
flutter-team-archive/engine@b7358b3 libtxt: cache font families that are remapped to the default font family
flutter-team-archive/engine@a530035 libtxt: fix leaks in Skia object reference counting
flutter-team-archive/engine@0c74fc9 [fuchsia] Fix use-after-free
flutter-team-archive/engine@b6d2dde [fuchsia] Fix build
flutter-team-archive/engine@1dd1264 [async] Adapt to libasync API changes.