Repository navigation
Clarify deprecation notice for jumpToWithoutSettling in scroll_position.dart - #167200
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
framework
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Indeed that's an improved deprecation message, thanks for cleaning this up.
| /// Creates a widget that builds its child while assigning it a key. | ||
| /// | ||
| /// This is useful when you want to preserve the state of a widget when it moves | ||
| /// around in the widget tree by associating it with a consistent key. |
There was a problem hiding this comment.
Just double checking, but did you mean to include this docs change in this PR? Fine either way as it looks like an improvement as well.
There was a problem hiding this comment.
#167198 Is approved to land, then we can return here. This still needs to be cleaned up.
|
Does the customer testing failure look like something to be concerned about? I missed that at first. |
|
Rebasing to see if it resolves the customer_testing failure. |
b42cbaa to
e19026a
Compare
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
This deprecation message update LGTM as well, can you remove the other doc changes that are in the other linked PR?
| /// Creates a widget that builds its child while assigning it a key. | ||
| /// | ||
| /// This is useful when you want to preserve the state of a widget when it moves | ||
| /// around in the widget tree by associating it with a consistent key. |
|
Rebasing now that the other change has landed. |
87c32be to
c0adf46
Compare
|
autosubmit label was removed for flutter/flutter/167200, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
Description
Improved the
@Deprecatedmessage forjumpToWithoutSettlingto clarify the risksand suggest appropriate alternatives like
jumpToor using a customScrollPosition.This makes the warning more informative for developers, in line with Flutter's documentation practices.
Checklist