Add ktlint test for generated files from templates by mboetger · Pull Request #167378 · flutter/flutter

mboetger · 2025-04-17T23:01:16Z

Creates a new test in analyze.dart that will generate kotlin files from .kt.tmpl and .kts.tmpl files and then run ktlint on them.

Fixes: #166497

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

auto-submit · 2025-04-18T18:13:03Z

autosubmit label was removed for flutter/flutter/167378, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter#167378)

flutter/flutter@3ed38e2...cfb887c 2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447) 2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434) 2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430) 2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428) 2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427) 2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382) 2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425) 2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122) 2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378) 2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420) 2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730) 2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887) 2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417) 2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307) 2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419) 2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414) 2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#167378)

Creates a new test in analyze.dart that will generate kotlin files from .kt.tmpl and .kts.tmpl files and then run ktlint on them. Fixes: flutter#166497 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…lutter#167378)

flutter/flutter@3ed38e2...cfb887c 2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447) 2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434) 2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430) 2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428) 2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427) 2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382) 2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425) 2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122) 2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378) 2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420) 2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730) 2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887) 2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417) 2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307) 2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419) 2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414) 2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

mboetger added the team-android Owned by Android platform team label Apr 17, 2025

mboetger requested a review from matanlurey as a code owner April 17, 2025 23:01

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. and removed team-android Owned by Android platform team labels Apr 17, 2025

mboetger requested review from ash2moon, gmackall and reidbaker April 17, 2025 23:06

reidbaker approved these changes Apr 18, 2025

View reviewed changes

Comment thread dev/bots/analyze.dart Outdated

Comment thread dev/bots/analyze.dart

reidbaker reviewed Apr 18, 2025

View reviewed changes

Comment thread dev/bots/analyze.dart

Add ktlint test for generated files from templates

b4426b9

mboetger force-pushed the ktlint-test branch from dbd0259 to b4426b9 Compare April 18, 2025 17:05

gmackall approved these changes Apr 18, 2025

View reviewed changes

reidbaker approved these changes Apr 18, 2025

View reviewed changes

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

mboetger added 2 commits April 18, 2025 18:15

Merge branch 'master' into ktlint-test

a0c9f65

Fix dart analyzer errors

8ae85bc

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit Bot added this pull request to the merge queue Apr 18, 2025

Merged via the queue into flutter:master with commit c74cd04 Apr 18, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

d05e4c4

…lutter#167378)

engine-flutter-autoroll mentioned this pull request Apr 19, 2025

Roll Flutter from 3ed38e24528a to 93e5d8120143 (15 revisions) flutter/packages#9115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

d738e83

…lutter#167378)

engine-flutter-autoroll mentioned this pull request Apr 19, 2025

Roll Flutter from 3ed38e24528a to 432fea845953 (16 revisions) flutter/packages#9116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

4b10181

…lutter#167378)

engine-flutter-autoroll mentioned this pull request Apr 20, 2025

Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) flutter/packages#9118

Merged

mboetger deleted the ktlint-test branch May 6, 2025 21:37

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

c91e1f2

…lutter#167378)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

0f94a7e

…lutter#167378)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

ce407a9

…lutter#167378)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

9336f2d

…lutter#167378)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

c74cd04 Add ktlint test for generated files from templates (flutter/f…

ec09665

…lutter#167378)

Navigation Menu

Repository navigation

Add ktlint test for generated files from templates - #167378

Add ktlint test for generated files from templates#167378
auto-submit[bot] merged 3 commits into
flutter:masterfrom
mboetger:ktlint-test

mboetger commented Apr 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mboetger commented Apr 17, 2025

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants