Add WidgetStatesController to ListTile by RamonFarizel · Pull Request #168878 · flutter/flutter

RamonFarizel · 2025-05-15T00:03:13Z

Add WidgetStatesController to ListTile

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-05-20T12:44:51Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168878 at sha 054bcea

flutter-dashboard · 2025-05-30T13:08:18Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168878 at sha 4aa2541

dkwingsmt · 2025-06-04T18:45:30Z

Gentle nudge @MitchellGoodwin (from triage)

RamonFarizel · 2025-06-20T10:33:40Z

@dkwingsmt @micaelcid Hi folks, just a reminder about this one.

dkwingsmt

LGTM. Sorry for the late review!

MitchellGoodwin

LGTM as well! Apologies for the late review.

MitchellGoodwin · 2025-06-30T21:57:03Z

  final bool internalAddSemanticForOnTap;

+  /// {@macro flutter.material.inkwell.statesController}
+  final MaterialStatesController? statesController;


Ideally this would be WidgetStateController, but as it's used throughout the file as MaterialState, it's probably better for now that this is MaterialStatesController.

Add WidgetStatesController to ListTile Fixes flutter#166611 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

RamonFarizel added 2 commits May 14, 2025 20:59

add materialStatesController

9bad9f5

format code

4763ce9

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 15, 2025

Merge branch 'master' into rf/list-title-controller

054bcea

flutter-dashboard Bot added the will affect goldens Changes to golden files label May 20, 2025

RamonFarizel added 2 commits May 21, 2025 09:13

Merge branch 'master' into rf/list-title-controller

17f3cdc

Merge branch 'master' into rf/list-title-controller

9c95800

dkwingsmt requested a review from MitchellGoodwin May 21, 2025 18:22

RamonFarizel added 3 commits May 28, 2025 15:20

Merge branch 'master' into rf/list-title-controller

366b2bd

Merge branch 'master' into rf/list-title-controller

8479f7a

Merge branch 'master' into rf/list-title-controller

4aa2541

Merge branch 'master' into rf/list-title-controller

8bd08de

dkwingsmt self-requested a review June 25, 2025 18:14

dkwingsmt approved these changes Jun 26, 2025

View reviewed changes

MitchellGoodwin approved these changes Jun 30, 2025

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025

auto-submit Bot added this pull request to the merge queue Jun 30, 2025

Merged via the queue into flutter:master with commit 319bd11 Jun 30, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025

engine-flutter-autoroll mentioned this pull request Jul 1, 2025

Roll Flutter from 2773c0c8e15e to 975f6d8bef99 (87 revisions) flutter/packages#9537

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

b64cf9b

engine-flutter-autoroll mentioned this pull request Jul 1, 2025

Roll Flutter from 2773c0c8e15e to 253cae121ef1 (88 revisions) flutter/packages#9538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

a7b67f0

engine-flutter-autoroll mentioned this pull request Jul 1, 2025

Roll Flutter from 2773c0c8e15e to 1b075f6b1836 (89 revisions) flutter/packages#9539

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

a13b856

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to a69ba5da50db (117 revisions) flutter/packages#9548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

52b5658

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to c6f9e801b2e4 (118 revisions) flutter/packages#9549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

60f6a9a

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 59ba3087e40d (119 revisions) flutter/packages#9550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

991cea3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

7541b51

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

5331b2f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

92e3371

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

ffd514f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

cec46ea

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

384ec5f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

c80541c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

e8accb9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

f2198b1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

f071dbe

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

7cf7e40

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

13f02a1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

07f1311

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

a0c2a7d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

f953d66

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

ffc1b19

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

f261c75

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

1c008dc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

bc8c064

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

f90c8f5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

319bd11 Add WidgetStatesController to ListTile (flutter/flutter#168878)

ae62c10

Navigation Menu

Repository navigation

Add WidgetStatesController to ListTile - #168878

Add WidgetStatesController to ListTile#168878
auto-submit[bot] merged 9 commits into
flutter:masterfrom
RamonFarizel:rf/list-title-controller

RamonFarizel commented May 15, 2025 •

edited by tirth-patel-nc

Loading

Uh oh!

flutter-dashboard Bot commented May 20, 2025

Uh oh!

flutter-dashboard Bot commented May 30, 2025

Uh oh!

dkwingsmt commented Jun 4, 2025

Uh oh!

RamonFarizel commented Jun 20, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

MitchellGoodwin left a comment

Uh oh!

MitchellGoodwin Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

RamonFarizel commented May 15, 2025 • edited by tirth-patel-nc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented May 20, 2025

Uh oh!

flutter-dashboard Bot commented May 30, 2025

Uh oh!

dkwingsmt commented Jun 4, 2025

Uh oh!

RamonFarizel commented Jun 20, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RamonFarizel commented May 15, 2025 •

edited by tirth-patel-nc

Loading