Skip to content

[Impeller] document reverse-y requirement for ImageFilter.shader - #169761

Merged
gaaclarke merged 3 commits into
flutter:masterfrom
jonahwilliams:document_reverse_y
May 30, 2025
Merged

[Impeller] document reverse-y requirement for ImageFilter.shader#169761
gaaclarke merged 3 commits into
flutter:masterfrom
jonahwilliams:document_reverse_y

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented May 30, 2025

Copy link
Copy Markdown
Contributor

Otherwise things are upside down.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label May 30, 2025
@jonahwilliams
jonahwilliams requested a review from gaaclarke May 30, 2025 20:24
gaaclarke
gaaclarke approved these changes May 30, 2025
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaaclarke
gaaclarke added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 291a689 May 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
b2fc02c 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
7e0cf0b 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
2297a28 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
df1550e 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
d479c2a 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
5e01d79 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
aaf774d 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
d50bdf2 
…der (flutter/flutter#169761)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
9518aef 
…der (flutter/flutter#169761)
@jonahwilliams jonahwilliams mentioned this pull request Jun 2, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
e36945d 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
52628fc 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
d7c2c8c 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
cb7d43c 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
1b34684 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
e093294 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
5a16088 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
403be63 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
eebe0e1 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
c007a00 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
c9b85b4 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
bbb0f2c 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
c66e496 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
8374a4e 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
ee2d085 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
7d2bbfc 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
3ed9b8d 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
a011b93 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
7ecf14b 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
3ceb128 
…der (flutter/flutter#169761)
@jonahwilliams jonahwilliams mentioned this pull request Jun 11, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jun 11, 2025
Jonah Williams
[impellerc] add GLES shader define. (#170375)
2773965 
Fixes #169429

For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
#169761 how to do it but
neglected to wire up the define. This fixes that.
GiacomoPignoni pushed a commit to plx-tech/flutter that referenced this pull request Jun 23, 2025
Jonah Williams @GiacomoPignoni
[impellerc] add GLES shader define. (#170375)
ce13b06 
Fixes flutter/flutter#169429

For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
flutter/flutter#169761 how to do it but
neglected to wire up the define. This fixes that.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
Jonah Williams @mboetger
[impellerc] add GLES shader define. (flutter#170375)
7069078 
Fixes flutter#169429

For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
flutter#169761 how to do it but
neglected to wire up the define. This fixes that.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
35509a1 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
2781137 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
b27c5ae 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
df8d334 
…der (flutter/flutter#169761)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
291a689 [Impeller] document reverse-y requirement for ImageFilter.sha…
2423102 
…der (flutter/flutter#169761)
@timcreatedit timcreatedit mentioned this pull request Sep 29, 2025
Closed
Nakiha pushed a commit to Nakiha/VoidPlayer-Flutter that referenced this pull request Sep 28, 2026
Jonah Williams
[impellerc] add GLES shader define. (#170375)
a744d24 
Fixes flutter/flutter#169429

For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
flutter/flutter#169761 how to do it but
neglected to wire up the define. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke