Skip to content

Re-split hot reload error and hot restart tests - #170368

Merged
auto-submit[bot] merged 2 commits into
masterfrom
hot_reload_web_error_unsplit
Jun 13, 2025
Merged

Re-split hot reload error and hot restart tests#170368
auto-submit[bot] merged 2 commits into
masterfrom
hot_reload_web_error_unsplit

Conversation

@mdebbar

@mdebbar mdebbar commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

After combining these 2 tests, they became very flaky, especially on Mac and Windows, but also on Linux.

Filed an issue: #170062

@mdebbar
mdebbar requested a review from srujzs June 10, 2025 17:45
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 10, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit 5b0706c Jun 13, 2025
@auto-submit
auto-submit Bot deleted the hot_reload_web_error_unsplit branch June 13, 2025 19:12
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
37f9fd7 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
3e36b0c 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
718399e 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
b3ec70c 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
5297c61 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
c28d5f7 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
00e1873 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
1aac348 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
976cf1c 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
a715803 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
3d4df19 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
331f2e8 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
1fb183f 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
9c200c4 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
246d3d2 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
9ac865c 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
d9c3866 
…ter#170368)
mdebbar added a commit that referenced this pull request Jun 24, 2025
@mdebbar
Revert "Re-split hot reload error and hot restart tests (#170368)"
b0d993a 
This reverts commit 5b0706c.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@mdebbar @mboetger
Re-split hot reload error and hot restart tests (flutter#170368)
5cc3ad8 
After [combining](flutter#169860) these
2 tests, they became very flaky, especially on Mac and Windows, but also
on Linux.

Filed an issue: flutter#170062
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
3d42f21 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
0501630 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
f972fcc 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
26d1984 
…ter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
5b0706c Re-split hot reload error and hot restart tests (flutter/flut…
719e107 
…ter#170368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srujzs srujzs srujzs approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @srujzs