Repository navigation
Reland "[native assets] Build dev dependencies in flutter test integration_test" - #170686
Merged
Merged
Conversation
github-actions
Bot
added
the
tool
matanlurey
approved these changes
Jun 16, 2025
dcharkes
added
the
autosubmit
bkonyi
approved these changes
Jun 16, 2025
flutter-dashboard
Bot
removed
the
autosubmit
Contributor
|
reason for revert: Broke |
![auto-submit[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
auto-submit
Bot
removed
the
revert
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…est integration_test`" (#170686)" (#170718) <!-- start_original_pr_link --> Reverts: #170686 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Broke [`Windows_mokey native_assets_android`](https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20native_assets_android/2518/overview) again. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Reland #170374 Original PR in first commit. Fixes in subsequent commits: * `flutter` is not on the `PATH` in the device lab, use `_flutterBin` (consistent with the rest of the test). Fixes `flutter` not found. * `flutter test integration_test` now does not build assets for the host anymore. `flutter test` builds assets for the host. The `TestCommand` is now special-case to check for `_isIntegrationTest`. Fixes `clang++` not found. (It's the compiler for Linux, but we are running integration tests on an Android device.) Tests pass locally with: ``` $ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android ``` Note: * The device lab tests are not run on presubmit until #170682 is addressed. * The emulator tests are not run at all atm: #170529. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…ration_test`" (#170728) Reland #170686. Closes: #168961. Original PR in first commit. Fix in subsequent commit: * Do process invocation of `flutter pub add` in a different way. Fixes: `ProcessException: %1 is not a valid Win32 application` Reproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to `DeviceOperatingSystem.windows` and verified the `flutter pub add` call now succeeds. (Also, moved the add integration test into the create test project to avoid having multiple `flutter pub get`s.) Third time is the charm.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…st integration_test`" (flutter/flutter#170686)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…ration_test`" (flutter#170686) Reland flutter#170374 Original PR in first commit. Fixes in subsequent commits: * `flutter` is not on the `PATH` in the device lab, use `_flutterBin` (consistent with the rest of the test). Fixes `flutter` not found. * `flutter test integration_test` now does not build assets for the host anymore. `flutter test` builds assets for the host. The `TestCommand` is now special-case to check for `_isIntegrationTest`. Fixes `clang++` not found. (It's the compiler for Linux, but we are running integration tests on an Android device.) Tests pass locally with: ``` $ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android ``` Note: * The device lab tests are not run on presubmit until flutter#170682 is addressed. * The emulator tests are not run at all atm: flutter#170529.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…est integration_test`" (flutter#170686)" (flutter#170718) <!-- start_original_pr_link --> Reverts: flutter#170686 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Broke [`Windows_mokey native_assets_android`](https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20native_assets_android/2518/overview) again. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Reland flutter#170374 Original PR in first commit. Fixes in subsequent commits: * `flutter` is not on the `PATH` in the device lab, use `_flutterBin` (consistent with the rest of the test). Fixes `flutter` not found. * `flutter test integration_test` now does not build assets for the host anymore. `flutter test` builds assets for the host. The `TestCommand` is now special-case to check for `_isIntegrationTest`. Fixes `clang++` not found. (It's the compiler for Linux, but we are running integration tests on an Android device.) Tests pass locally with: ``` $ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android ``` Note: * The device lab tests are not run on presubmit until flutter#170682 is addressed. * The emulator tests are not run at all atm: flutter#170529. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…ration_test`" (flutter#170728) Reland flutter#170686. Closes: flutter#168961. Original PR in first commit. Fix in subsequent commit: * Do process invocation of `flutter pub add` in a different way. Fixes: `ProcessException: %1 is not a valid Win32 application` Reproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to `DeviceOperatingSystem.windows` and verified the `flutter pub add` call now succeeds. (Also, moved the add integration test into the create test project to avoid having multiple `flutter pub get`s.) Third time is the charm.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…st integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…st integration_test`" (flutter/flutter#170686)
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
…est integration_test`" (#170686)" (#170718) <!-- start_original_pr_link --> Reverts: flutter/flutter#170686 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Broke [`Windows_mokey native_assets_android`](https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20native_assets_android/2518/overview) again. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Reland flutter/flutter#170374 Original PR in first commit. Fixes in subsequent commits: * `flutter` is not on the `PATH` in the device lab, use `_flutterBin` (consistent with the rest of the test). Fixes `flutter` not found. * `flutter test integration_test` now does not build assets for the host anymore. `flutter test` builds assets for the host. The `TestCommand` is now special-case to check for `_isIntegrationTest`. Fixes `clang++` not found. (It's the compiler for Linux, but we are running integration tests on an Android device.) Tests pass locally with: ``` $ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android ``` Note: * The device lab tests are not run on presubmit until flutter/flutter#170682 is addressed. * The emulator tests are not run at all atm: flutter/flutter#170529. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
…ration_test`" (#170728) Reland flutter/flutter#170686. Closes: flutter/flutter#168961. Original PR in first commit. Fix in subsequent commit: * Do process invocation of `flutter pub add` in a different way. Fixes: `ProcessException: %1 is not a valid Win32 application` Reproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to `DeviceOperatingSystem.windows` and verified the `flutter pub add` call now succeeds. (Also, moved the add integration test into the create test project to avoid having multiple `flutter pub get`s.) Third time is the charm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #170374
Original PR in first commit. Fixes in subsequent commits:
flutteris not on thePATHin the device lab, use_flutterBin(consistent with the rest of the test).Fixes
flutternot found.flutter test integration_testnow does not build assets for the host anymore.flutter testbuilds assets for the host. TheTestCommandis now special-case to check for_isIntegrationTest.Fixes
clang++not found. (It's the compiler for Linux, but we are running integration tests on an Android device.)Tests pass locally with:
Note:
native_assetstests #170682 is addressed.