Repository navigation
Fix expectLater to not wrap the delegate in a guard - #17085
Merged
Merged
Conversation
This was referenced Apr 29, 2018
gspencergoog
approved these changes
Apr 30, 2018
Contributor
|
|
Hixie
reviewed
Apr 30, 2018
| // We can't wrap the delegate in a guard, or we'll hit async barriers in | ||
| // [TestWidgetsFlutterBinding] while we're waiting for the matcher to complete | ||
| TestAsyncUtils.guardSync(); | ||
| return test_package.expectLater(actual, matcher, reason: reason, skip: skip); |
Contributor
There was a problem hiding this comment.
What I'm worried about is that this will mean you can forget to await this method, then call something like pump, and we won't catch it.
Why are we hitting async barriers if you await this future?
Contributor
Author
There was a problem hiding this comment.
While still awaiting the async matcher, I was hitting the async barrier here:
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17063
#16859