Repository navigation
Preliminaries for scroll anchoring - #1710
Merged
Merged
Conversation
Contributor
Author
| if (scrollVelocity.dx.abs() > _kMinFlingVelocity) { | ||
| final int selectionDelta = scrollVelocity.dx > 0 ? -1 : 1; | ||
| if (scrollVelocity.abs() > _kMinFlingVelocity) { | ||
| final int selectionDelta = scrollVelocity.sign.round(); |
Contributor
There was a problem hiding this comment.
truncate() is probably more precisely the semantic we're going for here than round()
Contributor
|
lgtm |
abarth
force-pushed
the
scroll_anchor
branch
2 times, most recently
from
February 9, 2016 17:58
589e3ef to
186a10e
Compare
These classes now share more code and have feature parity.
abarth
added a commit
that referenced
this pull request
Feb 9, 2016
Preliminaries for scroll anchoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches are warmups for adding support for scroll anchors.